Re: [PATCH v4 9/9] drm/vkms: convert to use faux_device

[Louis Chauvet <louis.chauvet@bootlin.com>]

Le 25/02/2025 à 12:41, Thomas Zimmermann a écrit :
> Hi
> 
> Am 10.02.25 um 15:37 schrieb Louis Chauvet:
>> On 10/02/25 - 13:30, Greg Kroah-Hartman wrote:
>>> The vkms driver does not need to create a platform device, as there is
>>> no real platform resources associated it,  it only did so because it was
>>> simple to do that in order to get a device to use for resource
>>> management of drm resources.  Change the driver to use the faux device
>>> instead as this is NOT a real platform device.
>>>
>>> Cc: Louis Chauvet <louis.chauvet@bootlin.com>
>>> Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
>>> Cc: Simona Vetter <simona@ffwll.ch>
>>> Cc: Melissa Wen <melissa.srw@gmail.com>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> Cc: Maxime Ripard <mripard@kernel.org>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: David Airlie <airlied@gmail.com>
>>> Cc: dri-devel@lists.freedesktop.org
>>> Reviewed-by: Lyude Paul <lyude@redhat.com>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
>> Tested-by: Louis Chauvet <louis.chauvet@bootlin.com>
>> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
>>
>> Thanks for the modification, it seems to work.
> 
> Should this patch be merged through DRM trees? drm-misc-next is at
> v6.14-rc4 and has struct faux_device.

Hi,

I was not aware the faux-device was merged, as it is a new feature, I 
expected it to reach drm-misc-next on 6.15-rc1.

I plan to merge [1] today/tomorrow (well tested with platform_device), 
and then I will submit an updated version of this patch (only trivial 
conflicts, but never tested with multiple VKMS devices).

[1]:https://lore.kernel.org/all/20250218101214.5790-1-jose.exposito89@gmail.com/

Thanks,
Louis Chauvet

> Best regards
> Thomas
> 
> 
> 
>>
>> Louis chauvet
>>
> 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com