From: John Hubbard <jhubbard@nvidia.com>
To: Timur Tabi <ttabi@nvidia.com>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
Alexandre Courbot <acourbot@nvidia.com>,
"dakr@kernel.org" <dakr@kernel.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v5 09/11] gpu: nova-core: add FalconUCodeDescV2 support
Date: Fri, 9 Jan 2026 11:13:37 -0800 [thread overview]
Message-ID: <4a11be38-e752-407d-98d5-658086107d1e@nvidia.com> (raw)
In-Reply-To: <84b40c4d-ef8c-4b7e-b8f8-055e57516a55@nvidia.com>
On 1/9/26 10:59 AM, John Hubbard wrote:
> On 1/9/26 10:11 AM, Timur Tabi wrote:
>> On Thu, 2026-01-08 at 18:53 -0800, John Hubbard wrote:
>>> It may have its own imperfections, but this is *approximately* what I'd
>>> prefer (below). I believe that it strikes the right balance between
>>> simplicity and Rust idiomatic code--and it's not any larger than what
>>> you started with.
>>>
>>> And it won't cost you any time to implement, since this already works:
>>
>> Do you realize that this is almost identical to my V1 of this patchset? We've come full circle.
>>
>
> I hope I didn't review that one in detail. This is really pretty funny. :)
>
But more seriously, we are all still calibrating ourselves about how
far to go with various Rust abstractions, in various situations. Here,
"we" means all of us involved in writing and reviewing the various
Nova patchsets.
And we have different levels of experience with Rust, kernel, and
GPU drivers. *And* that's changing as we continue to work together.
So I do expect this sort of situation to start converging over time.
Meanwhile I want to apologize for you getting jerked around on
reviews. It really will improve, I'm confident of that.
thanks,
--
John Hubbard
next prev parent reply other threads:[~2026-01-09 19:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 4:59 [PATCH v5 00/11] gpu: nova-core: add Turing support Timur Tabi
2026-01-03 4:59 ` [PATCH v5 01/11] gpu: nova-core: rename Imem to ImemSecure Timur Tabi
2026-01-03 4:59 ` [PATCH v5 02/11] gpu: nova-core: add ImemNonSecure section infrastructure Timur Tabi
2026-01-03 4:59 ` [PATCH v5 03/11] gpu: nova-core: support header parsing on Turing/GA100 Timur Tabi
2026-01-03 4:59 ` [PATCH v5 04/11] gpu: nova-core: add support for Turing/GA100 fwsignature Timur Tabi
2026-01-03 4:59 ` [PATCH v5 05/11] gpu: nova-core: add NV_PFALCON_FALCON_DMATRFCMD::with_falcon_mem() Timur Tabi
2026-01-03 4:59 ` [PATCH v5 06/11] gpu: nova-core: move some functions into the HAL Timur Tabi
2026-01-03 4:59 ` [PATCH v5 07/11] gpu: nova-core: Add basic Turing HAL Timur Tabi
2026-01-03 4:59 ` [PATCH v5 08/11] gpu: nova-core: add Falcon HAL method supports_dma() Timur Tabi
2026-01-09 0:25 ` John Hubbard
2026-01-03 4:59 ` [PATCH v5 09/11] gpu: nova-core: add FalconUCodeDescV2 support Timur Tabi
2026-01-09 2:53 ` John Hubbard
2026-01-09 18:11 ` Timur Tabi
2026-01-09 18:59 ` John Hubbard
2026-01-09 19:13 ` John Hubbard [this message]
2026-01-13 1:08 ` John Hubbard
2026-01-13 0:00 ` Joel Fernandes
2026-01-14 0:56 ` Timur Tabi
2026-01-14 0:59 ` Joel Fernandes
2026-01-03 4:59 ` [PATCH v5 10/11] gpu: nova-core: align LibosMemoryRegionInitArgument size to page size Timur Tabi
2026-01-09 3:15 ` John Hubbard
2026-01-03 4:59 ` [PATCH v5 11/11] gpu: nova-core: add PIO support for loading firmware images Timur Tabi
2026-01-03 12:53 ` kernel test robot
2026-01-05 23:44 ` [PATCH v5 00/11] gpu: nova-core: add Turing support Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a11be38-e752-407d-98d5-658086107d1e@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=joelagnelf@nvidia.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox