From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Ariel Miculas <amiculas@cisco.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me
Subject: Re: [PATCH v3] rust: helpers: sort includes alphabetically in rust/helpers.c
Date: Wed, 26 Apr 2023 17:55:25 -0300 [thread overview]
Message-ID: <4b8e3c30-9626-dffd-0aff-4b5c650154ad@gmail.com> (raw)
In-Reply-To: <20230426204923.16195-1-amiculas@cisco.com>
On 4/26/23 17:49, Ariel Miculas wrote:
> Sort the #include directives of rust/helpers.c alphabetically and add a
> comment specifying this. The reason for this is to improve readability
> and to be consistent with the other files with a similar approach within
> 'rust/'.
>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1003
> Signed-off-by: Ariel Miculas <amiculas@cisco.com>
> ---
> [...]
Shouldn't the link use the `Link: <url> [1]` format? Otherwise LGTM.
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-04-26 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 20:28 [PATCH] rust: Sort rust/helpers.c's #include directives Ariel Miculas
2023-04-25 20:37 ` Miguel Ojeda
2023-04-26 8:13 ` Ariel Miculas
2023-04-26 8:23 ` Ariel Miculas
2023-04-26 8:17 ` Ariel Miculas
2023-04-26 17:55 ` Miguel Ojeda
2023-04-26 20:49 ` [PATCH v3] rust: helpers: sort includes alphabetically in rust/helpers.c Ariel Miculas
2023-04-26 20:55 ` Martin Rodriguez Reboredo [this message]
2023-04-26 21:04 ` Ariel Miculas
2023-04-26 21:28 ` Miguel Ojeda
2023-04-27 12:36 ` Gary Guo
2023-07-19 20:01 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b8e3c30-9626-dffd-0aff-4b5c650154ad@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=amiculas@cisco.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).