Re: [PATCH v2] rust: add trylock method support for lock backend

[Waiman Long <longman@redhat.com>]

On 9/24/24 03:02, Boqun Feng wrote:
>> +
>> +int rust_helper_spin_trylock(spinlock_t *lock)
>> +{
>> +	return spin_trylock(lock);
>> +}
>> diff --git a/rust/kernel/sync/lock.rs b/rust/kernel/sync/lock.rs
>> index f6c34ca4d819..f4e51a5a1f23 100644
>> --- a/rust/kernel/sync/lock.rs
>> +++ b/rust/kernel/sync/lock.rs
>> @@ -58,6 +58,13 @@ unsafe fn init(
>>       #[must_use]
>>       unsafe fn lock(ptr: *mut Self::State) -> Self::GuardState;
>>   
>> +    /// Tries to acquire the lock without blocking.
> As I suggested in v1, "without blocking" is not accurate here because
> a lock can be a spinlock. So you can just remove it. I think the word
> "Tries" itself implies "neither busy waiting nor blocking".

Actually a spinlock in a PREEMPT_RT kernel is a sleeping lock. Not all 
people will associate "Tries" with not blocking. Anyway, I don't think 
it is a problem with the "without blocking" phrase.

Cheers,
Longman