Re: [PATCH v2] rust: list: Add unsafe for container_of

[Philipp Stanner <phasta@mailbox.org>]

On Tue, 2025-11-18 at 09:20 +0100, Miguel Ojeda wrote:
> On Tue, Nov 18, 2025 at 8:29 AM Philipp Stanner <phasta@kernel.org> wrote:
> > 
> > For unknown reasons, that problem was so far not visible and only gets
> > visible once one utilizes the list implementation from within the core
> > crate:
> 
> What do you mean by "unknown reasons"? The reason is known -- please
> refer to my message in the other thread. It should be mentioned in the
> log, including the link to the compiler issue.

OK.

> 
> Also, I assume you meant `kernel` crate, not `core`.
> 
> > Cc: stable@vger.kernel.org # v6.17+
> 
> No need to mention the kernel version if the Fixes tags implies it. In
> fact, it is more confusing, since it looks like there is a version
> where it should not be applied to.

It's absolutely common to provide it. If you feel better without it, I
can omit it, I guess.

> 
> > -                let container = $crate::container_of!(
> > +                let container = unsafe { $crate::container_of!(
> >                      links_field, $crate::list::ListLinksSelfPtr<Self, $num>, inner
> > -                );
> > +                ) };
> 
> Unsafe blocks require `// SAFETY: ...` comments.

Ah, right. Overlooked that because the other section already has one.

> 
> Also, please double-check if this is the formatting that `rustfmt` would use.

I ran rustfmt.


P.