From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: "Ethan D. Twardy" <ethan.twardy@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Tom Rix" <trix@redhat.com>, "Tiago Lam" <tiagolam@gmail.com>,
"Kees Cook" <keescook@chromium.org>,
"Finn Behrens" <me@kloenk.de>,
"open list:RUST" <rust-for-linux@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:CLANG/LLVM BUILD SUPPORT" <llvm@lists.linux.dev>
Subject: Re: [PATCH v2 1/1] scripts/rust_is_available: Fix clang version check
Date: Sun, 28 May 2023 11:39:32 -0300 [thread overview]
Message-ID: <525fee98-c694-6a38-cd1e-dd7efd806620@gmail.com> (raw)
In-Reply-To: <20230528131802.6390-2-ethan.twardy@gmail.com>
On 5/28/23 10:18, Ethan D. Twardy wrote:
> [...]
> --- a/scripts/rust_is_available.sh
> +++ b/scripts/rust_is_available.sh
> @@ -102,8 +102,8 @@ fi
> # Check that the `libclang` used by the Rust bindings generator is suitable.
> bindgen_libclang_version=$( \
> LC_ALL=C "$BINDGEN" $(dirname $0)/rust_is_available_bindgen_libclang.h 2>&1 >/dev/null \
> - | grep -F 'clang version ' \
> - | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' \
> + | grep -oE 'clang version [0-9]+\.[0-9]+\.[0-9]+' \
> + | cut -d' ' -f3 \
> | head -n 1 \
> )
> bindgen_libclang_min_version=$($min_tool_version llvm)
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Tested-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-05-28 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 13:18 [PATCH v2 0/1] Fix libclang version check for rustavailable Ethan D. Twardy
2023-05-28 13:18 ` [PATCH v2 1/1] scripts/rust_is_available: Fix clang version check Ethan D. Twardy
2023-05-28 14:39 ` Martin Rodriguez Reboredo [this message]
2023-06-14 12:08 ` Ethan D. Twardy
2023-06-14 16:44 ` Martin Rodriguez Reboredo
2023-06-16 0:41 ` Miguel Ojeda
2023-06-16 0:30 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525fee98-c694-6a38-cd1e-dd7efd806620@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=ethan.twardy@gmail.com \
--cc=gary@garyguo.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=me@kloenk.de \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tiagolam@gmail.com \
--cc=trix@redhat.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).