From: Timur Tabi <ttabi@nvidia.com>
To: "dakr@kernel.org" <dakr@kernel.org>, John Hubbard <jhubbard@nvidia.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
"lossin@kernel.org" <lossin@kernel.org>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
Zhi Wang <zhiw@nvidia.com>, "simona@ffwll.ch" <simona@ffwll.ch>,
"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
Edwin Peer <epeer@nvidia.com>,
"airlied@gmail.com" <airlied@gmail.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"gary@garyguo.net" <gary@garyguo.net>,
Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8 type
Date: Sat, 8 Nov 2025 05:03:53 +0000 [thread overview]
Message-ID: <5342a0f10a3e9ef7d3165bd8912bd042ae7f68f5.camel@nvidia.com> (raw)
In-Reply-To: <20251108043945.571266-4-jhubbard@nvidia.com>
On Fri, 2025-11-07 at 20:39 -0800, John Hubbard wrote:
> /// Enum representation of the GPU generation.
> -#[derive(fmt::Debug)]
> +#[derive(fmt::Debug, Default, Copy, Clone)]
> +#[repr(u8)]
> pub(crate) enum Architecture {
> + #[default]
> Turing = 0x16,
> Ampere = 0x17,
> Ada = 0x19,
> @@ -142,6 +144,13 @@ fn try_from(value: u8) -> Result<Self> {
> }
> }
Does it make sense to designate a default Architecture? Turing is not a fallback for Ampere --
you can't boot an Ampere with Turing's HAL. Also, we don't even make Turing cards any more, so
over time, Turing will be less and less common.
next prev parent reply other threads:[~2025-11-08 5:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 4:39 [PATCH v6 0/4] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-11-08 4:39 ` [PATCH v6 1/4] gpu: nova-core: implement Display for Spec John Hubbard
2025-11-08 5:02 ` Timur Tabi
2025-11-08 5:10 ` John Hubbard
2025-11-08 11:41 ` Alexandre Courbot
2025-11-09 9:47 ` Miguel Ojeda
2025-11-08 4:39 ` [PATCH v6 2/4] gpu: nova-core: prepare Spec and Revision types for boot0/boot42 John Hubbard
2025-11-08 4:39 ` [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8 type John Hubbard
2025-11-08 5:03 ` Timur Tabi [this message]
2025-11-08 5:08 ` John Hubbard
2025-11-08 11:45 ` Alexandre Courbot
2025-11-08 17:27 ` Timur Tabi
2025-11-12 3:36 ` John Hubbard
2025-11-08 4:39 ` [PATCH v6 4/4] gpu: nova-core: add boot42 support for next-gen GPUs John Hubbard
2025-11-08 5:09 ` Timur Tabi
2025-11-08 5:19 ` John Hubbard
2025-11-08 17:28 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5342a0f10a3e9ef7d3165bd8912bd042ae7f68f5.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).