From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: materoy@proton.me
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's #includes
Date: Wed, 26 Apr 2023 21:38:06 -0300 [thread overview]
Message-ID: <54523420-3705-25d9-2b32-1bef98f4f89e@gmail.com> (raw)
In-Reply-To: <20230426224748.34056-1-materoy@proton.me>
On 4/26/23 19:57, materoy@proton.me wrote:
> From: Roy Matero <materoy@proton.me>
>
> Fix sorting of rust/bindings/binding_helper.h's includes,
> to maintain consistency and rust idoms
>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1002
>
> Signed-off-by: Roy Matero <materoy@proton.me>
> ---
> rust/bindings/bindings_helper.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index 50e7a76d5455..dc8d97272e71 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -6,10 +6,10 @@
> * Sorted alphabetically.
> */
>
> -#include <linux/slab.h>
> #include <linux/refcount.h>
> -#include <linux/wait.h>
> #include <linux/sched.h>
> +#include <linux/slab.h>
> +#include <linux/wait.h>
>
> /* `bindgen` gets confused at certain things. */
> const gfp_t BINDINGS_GFP_KERNEL = GFP_KERNEL;
> --
> 2.40.1
>
>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-04-27 0:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 22:57 [PATCH] rust: bindings: fix sorting of rust/bindings/bindings_helper.h's #includes materoy
2023-04-27 0:38 ` Martin Rodriguez Reboredo [this message]
2023-05-03 10:45 ` Benno Lossin
2023-05-03 11:08 ` Miguel Ojeda
2023-05-03 10:59 ` [PATCH v1] rust: error: add ERESTARTSYS error code Alice Ryhl
2023-05-03 11:02 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54523420-3705-25d9-2b32-1bef98f4f89e@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=materoy@proton.me \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).