From: Benno Lossin <benno.lossin@proton.me>
To: Michael Vetter <jubalh@iodoru.org>, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: fix typos in documentation
Date: Tue, 20 Aug 2024 08:15:34 +0000 [thread overview]
Message-ID: <545c627c-4a91-483c-8613-8cf48656a9f3@proton.me> (raw)
In-Reply-To: <20240819205731.2163-1-jubalh@iodoru.org>
On 19.08.24 22:57, Michael Vetter wrote:
> Fix spelling mistakes in code comments.
>
> Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
---
Cheers,
Benno
> ---
> rust/kernel/init/macros.rs | 4 ++--
> rust/kernel/net/phy.rs | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/rust/kernel/init/macros.rs b/rust/kernel/init/macros.rs
> index 02ecedc4a..9a0c4650e 100644
> --- a/rust/kernel/init/macros.rs
> +++ b/rust/kernel/init/macros.rs
> @@ -145,7 +145,7 @@
> //! }
> //! }
> //! // Implement the internal `PinData` trait that marks the pin-data struct as a pin-data
> -//! // struct. This is important to ensure that no user can implement a rouge `__pin_data`
> +//! // struct. This is important to ensure that no user can implement a rogue `__pin_data`
> //! // function without using `unsafe`.
> //! unsafe impl<T> ::kernel::init::__internal::PinData for __ThePinData<T> {
> //! type Datee = Bar<T>;
> @@ -156,7 +156,7 @@
> //! // case no such fields exist, hence this is almost empty. The two phantomdata fields exist
> //! // for two reasons:
> //! // - `__phantom`: every generic must be used, since we cannot really know which generics
> -//! // are used, we declere all and then use everything here once.
> +//! // are used, we declare all and then use everything here once.
> //! // - `__phantom_pin`: uses the `'__pin` lifetime and ensures that this struct is invariant
> //! // over it. The lifetime is needed to work around the limitation that trait bounds must
> //! // not be trivial, e.g. the user has a `#[pin] PhantomPinned` field -- this is
> diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs
> index fd40b703d..91dac63ff 100644
> --- a/rust/kernel/net/phy.rs
> +++ b/rust/kernel/net/phy.rs
> @@ -491,7 +491,7 @@ impl<T: Driver> Adapter<T> {
> pub struct DriverVTable(Opaque<bindings::phy_driver>);
>
> // SAFETY: `DriverVTable` doesn't expose any &self method to access internal data, so it's safe to
> -// share `&DriverVTable` across execution context boundries.
> +// share `&DriverVTable` across execution context boundaries.
> unsafe impl Sync for DriverVTable {}
>
> /// Creates a [`DriverVTable`] instance from [`Driver`].
> --
> 2.35.3
>
>
next prev parent reply other threads:[~2024-08-20 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 20:57 [PATCH] rust: fix typos in documentation Michael Vetter
2024-08-20 7:32 ` Alice Ryhl
2024-08-20 8:15 ` Benno Lossin [this message]
2024-08-21 11:02 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545c627c-4a91-483c-8613-8cf48656a9f3@proton.me \
--to=benno.lossin@proton.me \
--cc=jubalh@iodoru.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).