* [PATCH] rust: fix typos in documentation
@ 2024-08-19 20:57 Michael Vetter
2024-08-20 7:32 ` Alice Ryhl
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Michael Vetter @ 2024-08-19 20:57 UTC (permalink / raw)
To: rust-for-linux; +Cc: Michael Vetter
Fix spelling mistakes in code comments.
Signed-off-by: Michael Vetter <jubalh@iodoru.org>
---
rust/kernel/init/macros.rs | 4 ++--
rust/kernel/net/phy.rs | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/rust/kernel/init/macros.rs b/rust/kernel/init/macros.rs
index 02ecedc4a..9a0c4650e 100644
--- a/rust/kernel/init/macros.rs
+++ b/rust/kernel/init/macros.rs
@@ -145,7 +145,7 @@
//! }
//! }
//! // Implement the internal `PinData` trait that marks the pin-data struct as a pin-data
-//! // struct. This is important to ensure that no user can implement a rouge `__pin_data`
+//! // struct. This is important to ensure that no user can implement a rogue `__pin_data`
//! // function without using `unsafe`.
//! unsafe impl<T> ::kernel::init::__internal::PinData for __ThePinData<T> {
//! type Datee = Bar<T>;
@@ -156,7 +156,7 @@
//! // case no such fields exist, hence this is almost empty. The two phantomdata fields exist
//! // for two reasons:
//! // - `__phantom`: every generic must be used, since we cannot really know which generics
-//! // are used, we declere all and then use everything here once.
+//! // are used, we declare all and then use everything here once.
//! // - `__phantom_pin`: uses the `'__pin` lifetime and ensures that this struct is invariant
//! // over it. The lifetime is needed to work around the limitation that trait bounds must
//! // not be trivial, e.g. the user has a `#[pin] PhantomPinned` field -- this is
diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs
index fd40b703d..91dac63ff 100644
--- a/rust/kernel/net/phy.rs
+++ b/rust/kernel/net/phy.rs
@@ -491,7 +491,7 @@ impl<T: Driver> Adapter<T> {
pub struct DriverVTable(Opaque<bindings::phy_driver>);
// SAFETY: `DriverVTable` doesn't expose any &self method to access internal data, so it's safe to
-// share `&DriverVTable` across execution context boundries.
+// share `&DriverVTable` across execution context boundaries.
unsafe impl Sync for DriverVTable {}
/// Creates a [`DriverVTable`] instance from [`Driver`].
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: fix typos in documentation
2024-08-19 20:57 [PATCH] rust: fix typos in documentation Michael Vetter
@ 2024-08-20 7:32 ` Alice Ryhl
2024-08-20 8:15 ` Benno Lossin
2024-08-21 11:02 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2024-08-20 7:32 UTC (permalink / raw)
To: Michael Vetter; +Cc: rust-for-linux
On Mon, Aug 19, 2024 at 11:03 PM Michael Vetter <jubalh@iodoru.org> wrote:
>
> Fix spelling mistakes in code comments.
>
> Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: fix typos in documentation
2024-08-19 20:57 [PATCH] rust: fix typos in documentation Michael Vetter
2024-08-20 7:32 ` Alice Ryhl
@ 2024-08-20 8:15 ` Benno Lossin
2024-08-21 11:02 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Benno Lossin @ 2024-08-20 8:15 UTC (permalink / raw)
To: Michael Vetter, rust-for-linux
On 19.08.24 22:57, Michael Vetter wrote:
> Fix spelling mistakes in code comments.
>
> Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
---
Cheers,
Benno
> ---
> rust/kernel/init/macros.rs | 4 ++--
> rust/kernel/net/phy.rs | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/rust/kernel/init/macros.rs b/rust/kernel/init/macros.rs
> index 02ecedc4a..9a0c4650e 100644
> --- a/rust/kernel/init/macros.rs
> +++ b/rust/kernel/init/macros.rs
> @@ -145,7 +145,7 @@
> //! }
> //! }
> //! // Implement the internal `PinData` trait that marks the pin-data struct as a pin-data
> -//! // struct. This is important to ensure that no user can implement a rouge `__pin_data`
> +//! // struct. This is important to ensure that no user can implement a rogue `__pin_data`
> //! // function without using `unsafe`.
> //! unsafe impl<T> ::kernel::init::__internal::PinData for __ThePinData<T> {
> //! type Datee = Bar<T>;
> @@ -156,7 +156,7 @@
> //! // case no such fields exist, hence this is almost empty. The two phantomdata fields exist
> //! // for two reasons:
> //! // - `__phantom`: every generic must be used, since we cannot really know which generics
> -//! // are used, we declere all and then use everything here once.
> +//! // are used, we declare all and then use everything here once.
> //! // - `__phantom_pin`: uses the `'__pin` lifetime and ensures that this struct is invariant
> //! // over it. The lifetime is needed to work around the limitation that trait bounds must
> //! // not be trivial, e.g. the user has a `#[pin] PhantomPinned` field -- this is
> diff --git a/rust/kernel/net/phy.rs b/rust/kernel/net/phy.rs
> index fd40b703d..91dac63ff 100644
> --- a/rust/kernel/net/phy.rs
> +++ b/rust/kernel/net/phy.rs
> @@ -491,7 +491,7 @@ impl<T: Driver> Adapter<T> {
> pub struct DriverVTable(Opaque<bindings::phy_driver>);
>
> // SAFETY: `DriverVTable` doesn't expose any &self method to access internal data, so it's safe to
> -// share `&DriverVTable` across execution context boundries.
> +// share `&DriverVTable` across execution context boundaries.
> unsafe impl Sync for DriverVTable {}
>
> /// Creates a [`DriverVTable`] instance from [`Driver`].
> --
> 2.35.3
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rust: fix typos in documentation
2024-08-19 20:57 [PATCH] rust: fix typos in documentation Michael Vetter
2024-08-20 7:32 ` Alice Ryhl
2024-08-20 8:15 ` Benno Lossin
@ 2024-08-21 11:02 ` Miguel Ojeda
2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2024-08-21 11:02 UTC (permalink / raw)
To: Michael Vetter; +Cc: rust-for-linux
On Mon, Aug 19, 2024 at 11:03 PM Michael Vetter <jubalh@iodoru.org> wrote:
>
> Fix spelling mistakes in code comments.
>
> Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Applied to `rust-fixes` -- thanks everyone!
[ Reworded slightly. - Miguel ]
Cheers,
Miguel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-21 11:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-19 20:57 [PATCH] rust: fix typos in documentation Michael Vetter
2024-08-20 7:32 ` Alice Ryhl
2024-08-20 8:15 ` Benno Lossin
2024-08-21 11:02 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).