From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org,
rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Elle Rhumsaa" <elle@weathered-steel.dev>
Subject: Re: [PATCH v6 2/5] rust: pci: provide access to PCI Vendor values
Date: Tue, 26 Aug 2025 14:12:32 -0700 [thread overview]
Message-ID: <5813de21-dfa5-4277-8f33-8e15939eb74b@nvidia.com> (raw)
In-Reply-To: <c137a383-6dec-4031-af45-0da821574f38@kernel.org>
On 8/26/25 2:00 PM, Danilo Krummrich wrote:
> On 8/26/25 10:58 PM, John Hubbard wrote:
>> I have no idea "where appropriate" is, here. These are not hot paths, and
>> the existing pci.rs methods such as Device::vendor_id() are not inlined,
>> and so my initial approach is to just not inline any of this...
>
> I think we can inline those functions that only consist out of a single
> constructor (i.e. Self {...}) or a single function call either way.
Got it, thanks for clarifying!
thanks,
--
John Hubbard
next prev parent reply other threads:[~2025-08-26 21:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 2:03 [PATCH v6 0/5] rust, nova-core: PCI Class, Vendor support John Hubbard
2025-08-22 2:03 ` [PATCH v6 1/5] rust: pci: provide access to PCI Class and Class-related items John Hubbard
2025-08-25 12:17 ` Alexandre Courbot
2025-08-26 2:22 ` John Hubbard
2025-08-22 2:03 ` [PATCH v6 2/5] rust: pci: provide access to PCI Vendor values John Hubbard
2025-08-25 12:33 ` Alexandre Courbot
2025-08-25 12:47 ` Danilo Krummrich
2025-08-26 2:20 ` John Hubbard
2025-08-26 20:38 ` John Hubbard
2025-08-26 20:45 ` Danilo Krummrich
2025-08-26 20:58 ` John Hubbard
2025-08-26 21:00 ` Danilo Krummrich
2025-08-26 21:12 ` John Hubbard [this message]
2025-08-26 2:19 ` John Hubbard
2025-08-22 2:03 ` [PATCH v6 3/5] rust: pci: add DeviceId::from_class_and_vendor() method John Hubbard
2025-08-22 2:03 ` [PATCH v6 4/5] gpu: nova-core: avoid probing non-display/compute PCI functions John Hubbard
2025-08-22 2:03 ` [PATCH v6 5/5] rust: pci: use pci::Vendor instead of bindings::PCI_VENDOR_ID_* John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5813de21-dfa5-4277-8f33-8e15939eb74b@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=elle@weathered-steel.dev \
--cc=gary@garyguo.net \
--cc=joelagnelf@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).