rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
	Danilo Krummrich <dakr@kernel.org>
Cc: "Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Edwin Peer" <epeer@nvidia.com>, "Zhi Wang" <zhiw@nvidia.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Nouveau <nouveau-bounces@lists.freedesktop.org>
Subject: Re: [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs
Date: Wed, 29 Oct 2025 18:09:01 -0700	[thread overview]
Message-ID: <5fabf22d-1aec-42d2-99b5-fa13dcc94950@nvidia.com> (raw)
In-Reply-To: <DDV8W8QCD59Y.1HXCXMUS42JI5@nvidia.com>

On 10/29/25 5:54 PM, Alexandre Courbot wrote:
> On Thu Oct 30, 2025 at 9:37 AM JST, John Hubbard wrote:
>> On 10/29/25 6:54 AM, Alexandre Courbot wrote:
>>> On Wed Oct 29, 2025 at 8:26 PM JST, Danilo Krummrich wrote:
>>> <snip>
>> ...
>>
>> Done. Final code snippet looks like this:
>>
>>          let boot0 = regs::NV_PMC_BOOT_0::read(bar);
>>
>>          if boot0.use_boot42_instead() {
>>              Spec::try_from(regs::NV_PMC_BOOT_42::read(bar))
>>          } else {
>>              Spec::try_from(boot0)
>>          }
> 
> The previous code was returning `ENODEV` in case of NV04, aren't we
> losing this? Or is it moved to BOOT0's `try_from`?

Exactly, this is by intention now. We can fully determine the answers
via .use_boot42_instead(). The nv04 check is redundant.

thanks,
John Hubbard


  reply	other threads:[~2025-10-30  1:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29  3:03 [PATCH v3 0/2] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-10-29  3:03 ` [PATCH v3 1/2] gpu: nova-core: prepare Spec and Revision types for boot0/boot42 John Hubbard
2025-10-29  3:03 ` [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs John Hubbard
2025-10-29 11:26   ` Danilo Krummrich
2025-10-29 13:54     ` Alexandre Courbot
2025-10-30  0:37       ` John Hubbard
2025-10-30  0:54         ` Alexandre Courbot
2025-10-30  1:09           ` John Hubbard [this message]
2025-10-30  0:29     ` John Hubbard
2025-10-30  0:31       ` Timur Tabi
2025-10-30  0:35         ` John Hubbard
2025-10-30  1:01           ` Timur Tabi
2025-10-30  1:07             ` John Hubbard
2025-10-30  1:13               ` John Hubbard
2025-10-30  1:44               ` Timur Tabi
2025-10-30  5:30                 ` John Hubbard
2025-10-30 14:22                   ` Timur Tabi
2025-10-30 14:45                     ` Danilo Krummrich
2025-10-29 14:05   ` Alexandre Courbot
2025-10-31  0:04     ` John Hubbard
2025-11-02  0:34     ` John Hubbard
2025-11-02  2:41       ` Alexandre Courbot
2025-11-02  3:33         ` John Hubbard
2025-11-08  1:55           ` Alexandre Courbot
2025-11-08  2:03             ` John Hubbard
2025-10-29 15:02   ` Timur Tabi
2025-10-29 23:15     ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fabf22d-1aec-42d2-99b5-fa13dcc94950@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=epeer@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nouveau-bounces@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).