From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5EAB19CC02; Thu, 28 Nov 2024 13:55:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732802129; cv=pass; b=DPwSrmVki1zdq+oH9q8gN5Iu6FuA5L4t9ylTl7zZwKPmwok7CHRqNHBGAITM4kCzyl7UHaaKD9catevdPL5t0wjGhnViPWeyV+BMgqOILlmG9EMSQmlmIH9ZdVvER7no5rb2r84+x8Wy4ovcTmna50wbTijiT7s1BbVuJlDMjGc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732802129; c=relaxed/simple; bh=dxVfcpCdEmWF6/4VTEz2umc3C0G35aSHsb4ay57Pro4=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=gPLfqnR1zQlmxrVAJCDLrVD7HcO/mRma2TAQwwRjT5JgWp8CwIQ+JgPYwqOzeeqBtYAeV7GvGON/Dpuil3Iof/e9zaZq7d2obEAzRgcU6+/X8dCda6+Sbt+HdqN5Uf4Ht97S/m9gUrkYRMYgL66HvT+voNdnIOoMwFu73wWWM7Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=icyi0gsG; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="icyi0gsG" ARC-Seal: i=1; a=rsa-sha256; t=1732802096; cv=none; d=zohomail.com; s=zohoarc; b=l+9m7rzrhCK/WwVoK1f2OozTwSgJw9qGNA8s1UrTumYtGbumRUcK2CApnz9gr0epiQhgYx+fc7u42Peb/n0XfLol1UFTGN6eUCTm0+YrR4iwR51rQEp8ojMwRYSVORRyqxhv6UvHdFib2jY3IFW1lOIoZZ9Is0dlIa3AO/kp5DA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732802096; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=PoqsZLnhEF0znXNeMeDwKfsa/xTbLP8PvVVyRU6zuvI=; b=nqyRxGBMOnsyTIRPiZwSCEJwatwrSGzvHPgibgr0KpRmPWuGIrPSn+0OWPjJKMIM3QkzD0QAJ0CFooKcpoxG/vtpLPfsz+Ryv63Nkd9GDy5Se7r5jH/EGGCemTmIEGjICpbgc+MTNgxB1BUyUAU8I6n4k38ur1rdh7FmYm4a+iE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1732802096; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=PoqsZLnhEF0znXNeMeDwKfsa/xTbLP8PvVVyRU6zuvI=; b=icyi0gsGHOCYdgFdmY9KGqZkixFUsWtjIvIgIVyuNHxjhC6q89LuuBvDlbzMReYl mjTb7xYGuL3dDMh8w3b1Md1CKFLiTjGbog6bjtzlrjFu2m7lJr8hCh7I2nK+ME2R9kB +cCQMNoKVP3W5Vp/dqwe570CSgEQVXaF/KYZk/PE= Received: by mx.zohomail.com with SMTPS id 1732802096009385.5779076930594; Thu, 28 Nov 2024 05:54:56 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [WIP RFC v2 24/35] rust: drm/kms: Add RawCrtcState::active() From: Daniel Almeida In-Reply-To: <20240930233257.1189730-25-lyude@redhat.com> Date: Thu, 28 Nov 2024 10:54:41 -0300 Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Asahi Lina , Danilo Krummrich , mcanal@igalia.com, airlied@redhat.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , open list Content-Transfer-Encoding: quoted-printable Message-Id: <628D2479-AC44-402C-B15D-CBE0927F7053@collabora.com> References: <20240930233257.1189730-1-lyude@redhat.com> <20240930233257.1189730-25-lyude@redhat.com> To: Lyude Paul X-Mailer: Apple Mail (2.3826.200.121) X-ZohoMailClient: External Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: >=20 > A binding for checking drm_crtc_state.active. >=20 > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/crtc.rs | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/rust/kernel/drm/kms/crtc.rs b/rust/kernel/drm/kms/crtc.rs > index 43c7264402b07..ec9b58763dcca 100644 > --- a/rust/kernel/drm/kms/crtc.rs > +++ b/rust/kernel/drm/kms/crtc.rs > @@ -496,6 +496,14 @@ fn crtc(&self) -> &Self::Crtc { > // state > unsafe { ::from_raw((*self.as_raw()).crtc) } > } > + > + /// Returns whether or not the CRTC is active in this atomic = state. > + fn active(&self) -> bool { > + // SAFETY: `active` and the rest of its containing bitfield = can only be modified from the > + // atomic check context, and are invariant beyond that point = - so our interface can ensure > + // this access is serialized > + unsafe { (*self.as_raw()).active } > + } > } > impl RawCrtcState for T {} >=20 > --=20 > 2.46.1 >=20 >=20 LGTM. =E2=80=94 Daniel=