From: Dirk Behme <dirk.behme@gmail.com>
To: Gary Guo <gary@garyguo.net>, Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
"Will Deacon" <will@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/3] rust: implement `kernel::sync::Refcount`
Date: Sat, 5 Oct 2024 08:04:02 +0200 [thread overview]
Message-ID: <66651971-5d4b-44a3-9c6e-2aed6a7cfacc@gmail.com> (raw)
In-Reply-To: <20241004200836.137ce41f.gary@garyguo.net>
Am 04.10.24 um 21:08 schrieb Gary Guo:
> On Fri, 04 Oct 2024 20:51:22 +0200
> Andreas Hindborg <a.hindborg@kernel.org> wrote:
>
>> Hi Gary,
>>
>> "Gary Guo" <gary@garyguo.net> writes:
>>
>> [...]
>>
>>> diff --git a/rust/helpers/refcount.c b/rust/helpers/refcount.c
>>> index f47afc148ec3..39649443426b 100644
>>> --- a/rust/helpers/refcount.c
>>> +++ b/rust/helpers/refcount.c
>>> @@ -8,11 +8,26 @@ refcount_t rust_helper_REFCOUNT_INIT(int n)
>>> return (refcount_t)REFCOUNT_INIT(n);
>>> }
>>>
>>> +unsigned int rust_helper_refcount_read(refcount_t *r)
>>> +{
>>> + return refcount_read(r);
>>> +}
>>
>> +EXPORT_SYMBOL_GPL(rust_helper_refcount_read);
>>
>>> +
>>> +void rust_helper_refcount_set(refcount_t *r, int n)
>>> +{
>>> + refcount_set(r, n);
>>> +}
>>
>> +EXPORT_SYMBOL_GPL(rust_helper_refcount_set);
>>
>> BR Andreas
>>
>
> Helper symbol export is automatic after
> e26fa546042a (rust: kbuild: auto generate helper exports)
Yes :)
What results in a question, though:
When to use exports.h and when not?
There are several users of
#include <linux/export.h>
like
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/err.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/kunit.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/mutex.c
but some don't use it
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/rbtree.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/uaccess.c
Any rule?
Best regards
Dirk
next prev parent reply other threads:[~2024-10-05 6:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 15:52 [PATCH 0/3] implement `kernel::sync::Refcount` and convert users Gary Guo
2024-10-04 15:52 ` [PATCH 1/3] rust: implement `kernel::sync::Refcount` Gary Guo
2024-10-04 16:34 ` Dirk Behme
2024-10-04 18:51 ` Andreas Hindborg
2024-10-04 19:08 ` Gary Guo
2024-10-04 19:22 ` Andreas Hindborg
2024-10-05 6:04 ` Dirk Behme [this message]
2024-10-05 7:40 ` Greg KH
2024-10-05 13:31 ` Gary Guo
2024-10-05 14:26 ` Gary Guo
2024-10-07 12:30 ` Alice Ryhl
2024-10-04 15:52 ` [PATCH 2/3] rust: convert `Arc` to use `Refcount` Gary Guo
2024-10-05 12:06 ` Alice Ryhl
2024-10-05 13:12 ` Gary Guo
2024-10-04 15:52 ` [PATCH 3/3] rust: block: convert `block::mq` " Gary Guo
2024-10-04 16:43 ` Dirk Behme
2024-10-04 18:05 ` Andreas Hindborg
2024-10-05 15:08 ` Gary Guo
2024-10-05 18:47 ` Andreas Hindborg
2024-10-04 18:34 ` Andreas Hindborg
2024-10-04 18:43 ` Gary Guo
2024-10-04 19:18 ` Andreas Hindborg
2024-10-05 7:47 ` Greg KH
2024-10-05 9:48 ` Andreas Hindborg
2024-10-05 10:09 ` Greg KH
2024-10-05 10:10 ` Peter Zijlstra
2024-10-05 10:57 ` Andreas Hindborg
2024-10-05 11:05 ` Miguel Ojeda
2024-10-05 11:59 ` Alice Ryhl
2024-10-05 13:23 ` Gary Guo
2024-10-05 14:56 ` Andreas Hindborg
2024-10-10 8:39 ` Andreas Hindborg
2024-10-10 9:06 ` Andreas Hindborg
2024-10-10 9:48 ` Benno Lossin
2024-10-10 11:13 ` Andreas Hindborg
2024-10-05 14:51 ` Andreas Hindborg
2024-10-10 8:41 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66651971-5d4b-44a3-9c6e-2aed6a7cfacc@gmail.com \
--to=dirk.behme@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=will@kernel.org \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).