Rust for Linux List
 help / color / mirror / Atom feed
From: Daniel Almeida <daniel.almeida@collabora.com>
To: "Onur Özkan" <work@onurozkan.dev>
Cc: rust-for-linux@vger.kernel.org, ojeda@kernel.org,
	alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
	bjorn3_gh@protonmail.com, lossin@kernel.org,
	a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
	dakr@kernel.org, me@kloenk.dev, felipe_life@live.com,
	abdiel.janulgue@gmail.com, dirk.behme@de.bosch.com,
	daniel@sedlak.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: update error.rs documentation
Date: Wed, 30 Jul 2025 10:56:35 -0300	[thread overview]
Message-ID: <69315F62-A882-4622-B967-CCE206013C41@collabora.com> (raw)
In-Reply-To: <20250730120459.15607-1-work@onurozkan.dev>

Hi Onur,

> On 30 Jul 2025, at 09:04, Onur Özkan <work@onurozkan.dev> wrote:
> 
> Adds missing header links.
> 
> Signed-off-by: Onur Özkan <work@onurozkan.dev>

This is a v2 but there is no changelog.

Could you let us know what changed in future iterations, if any?

> ---
> rust/kernel/error.rs | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 3dee3139fcd4..dd3e4224218d 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -2,6 +2,8 @@
> 
> //! Kernel errors.
> //!
> +//! C header: [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)

Why is this mips file being referenced here? :)

> +//! C header: [`include/linux/errno.h`](srctree/include/linux/errno.h)
> //! C header: [`include/uapi/asm-generic/errno-base.h`](srctree/include/uapi/asm-generic/errno-base.h)
> 
> use crate::{
> --
> 2.50.0
> 
> 

— Daniel




  reply	other threads:[~2025-07-30 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 12:04 [PATCH v2] rust: update error.rs documentation Onur Özkan
2025-07-30 13:56 ` Daniel Almeida [this message]
2025-07-31  6:10   ` Onur Özkan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69315F62-A882-4622-B967-CCE206013C41@collabora.com \
    --to=daniel.almeida@collabora.com \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel@sedlak.dev \
    --cc=dirk.behme@de.bosch.com \
    --cc=felipe_life@live.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=me@kloenk.dev \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox