public inbox for rust-for-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Hsiu Che Yu <yu.whisper.personal@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Hsiu Che Yu" <yu.whisper.personal@gmail.com>,
	rust-for-linux@vger.kernel.org,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Lorenzo Stoakes" <ljs@kernel.org>,
	"Vlastimil Babka" <vbabka@kernel.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Uladzislau Rezki" <urezki@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] rust: alloc: fix `Vec::extend_with` SAFETY comment
Date: Mon, 27 Apr 2026 11:58:20 +0800	[thread overview]
Message-ID: <69eedee0.170a0220.230e6f.9507@mx.google.com> (raw)
In-Reply-To: <CANiq72nkXWhjK9iFRrhGtkMZGsvNE_zVsu4JnxaFRfxWL7RRdg@mail.gmail.com>

On Sun, Apr 26, 2026 at 03:10:12PM +0200, Miguel Ojeda wrote:
>For this case it doesn't matter too much, but in general, when
>something is a fix, we add a Fixes: tag (and in most cases Cc: stable@
>to accompany it). That helps backporting (when needed), adds context
>e.g. for reviewing (at times), etc.

I did miss the Fixes: tag — and what I hadn't thought about was that
these tags feed into the underlying tooling and workflows.
I'll make sure to include a Fixes: tag in fix-related commits going
forward (and will likely use one in the assert! patch coming up shortly)!

On Sun, Apr 26, 2026 at 03:10:12PM +0200, Miguel Ojeda wrote:
>By the way, now that I was looking at `reserve()`, the assert in the
>example there should probably use `>= 11` since there is already an
>element, instead of `>= 10`. That could be another similar patch.

I'll go ahead and work on that. I was thinking of changing it 
to `>= v.len() + 10`, which might make the intent clearer. 
For this patch, should I include the Suggested-by:, Reported-by:,
and Fixes: tags?

Thanks,
Hsiu

  reply	other threads:[~2026-04-27  3:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25  6:08 [PATCH] rust: alloc: add doc test for `Vec::extend_with` and fix comment Hsiu Che Yu
2026-04-25  6:32 ` Alexandre Courbot
2026-04-25  6:53   ` Hsiu Che Yu
2026-04-25  7:20     ` Alexandre Courbot
2026-04-25  9:00       ` Hsiu Che Yu
2026-04-25 10:16 ` [PATCH v2 0/2] rust: alloc: fix and test `Vec::extend_with` Hsiu Che Yu
2026-04-25 10:16   ` [PATCH v2 1/2] rust: alloc: add doc test for `Vec::extend_with` Hsiu Che Yu
2026-04-26  3:58     ` Alexandre Courbot
2026-04-25 10:16   ` [PATCH v2 2/2] rust: alloc: fix `Vec::extend_with` SAFETY comment Hsiu Che Yu
2026-04-25 15:17     ` Alexandre Courbot
2026-04-26 13:10     ` Miguel Ojeda
2026-04-27  3:58       ` Hsiu Che Yu [this message]
2026-04-26  4:00   ` [PATCH v2 0/2] rust: alloc: fix and test `Vec::extend_with` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69eedee0.170a0220.230e6f.9507@mx.google.com \
    --to=yu.whisper.personal@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox