From: Danilo Krummrich <dakr@kernel.org>
To: Timur Tabi <ttabi@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>,
"lossin@kernel.org" <lossin@kernel.org>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
Zhi Wang <zhiw@nvidia.com>, "simona@ffwll.ch" <simona@ffwll.ch>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
Edwin Peer <epeer@nvidia.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Alexandre Courbot <acourbot@nvidia.com>,
"gary@garyguo.net" <gary@garyguo.net>,
Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs
Date: Thu, 30 Oct 2025 15:45:56 +0100 [thread overview]
Message-ID: <6ac08d3e-6057-4869-ae41-03a0f900a0bb@kernel.org> (raw)
In-Reply-To: <18f013a69371ecd86783d09f73c7fb66d860e7df.camel@nvidia.com>
On 10/30/25 3:22 PM, Timur Tabi wrote:
> On Wed, 2025-10-29 at 22:30 -0700, John Hubbard wrote:
>> However, I don't want anyone to have to risk reading boot42 on some
>> ancient GPU (earlier than Fermi, even), with uncertain results.
>>
>> And our HW team has promised to leave behind arch0==0, arch1==1 in
>> in boot0, more or less forever, specifically to help us out here.
>>
>> With that in mind, I *do* want to read boot0 for the forseeable future,
>> as a guide to whether to look at boot42. I really think that is the
>> way to thread the needle here.
>
> Sure, and this is exactly what is_ancient_gpu() does. It tells you whether to use boot42
> instead of boot0. It is the only function that looks at boot0.
I think you're indeed talking about the same thing, but thinking differently
about the implementation details.
A standalone is_ancient_gpu() function called from probe() like
if is_ancient_gpu(bar) {
return Err(ENODEV);
}
is what we would probably do in C, but in Rust we should just call
let spec = Spec::new()?;
from probe() and Spec::new() will return Err(ENODEV) when it run into an ancient
GPU spec internally.
next prev parent reply other threads:[~2025-10-30 14:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 3:03 [PATCH v3 0/2] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-10-29 3:03 ` [PATCH v3 1/2] gpu: nova-core: prepare Spec and Revision types for boot0/boot42 John Hubbard
2025-10-29 3:03 ` [PATCH v3 2/2] gpu: nova-core: add boot42 support for next-gen GPUs John Hubbard
2025-10-29 11:26 ` Danilo Krummrich
2025-10-29 13:54 ` Alexandre Courbot
2025-10-30 0:37 ` John Hubbard
2025-10-30 0:54 ` Alexandre Courbot
2025-10-30 1:09 ` John Hubbard
2025-10-30 0:29 ` John Hubbard
2025-10-30 0:31 ` Timur Tabi
2025-10-30 0:35 ` John Hubbard
2025-10-30 1:01 ` Timur Tabi
2025-10-30 1:07 ` John Hubbard
2025-10-30 1:13 ` John Hubbard
2025-10-30 1:44 ` Timur Tabi
2025-10-30 5:30 ` John Hubbard
2025-10-30 14:22 ` Timur Tabi
2025-10-30 14:45 ` Danilo Krummrich [this message]
2025-10-29 14:05 ` Alexandre Courbot
2025-10-31 0:04 ` John Hubbard
2025-11-02 0:34 ` John Hubbard
2025-11-02 2:41 ` Alexandre Courbot
2025-11-02 3:33 ` John Hubbard
2025-11-08 1:55 ` Alexandre Courbot
2025-11-08 2:03 ` John Hubbard
2025-10-29 15:02 ` Timur Tabi
2025-10-29 23:15 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac08d3e-6057-4869-ae41-03a0f900a0bb@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).