From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D42D355F47 for ; Sat, 3 Oct 2026 16:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791046254; cv=none; b=f8kkrdNA/ay14JBunf8yMMcACdAnNtQ8nlPW44hLEl9fqmMO2BsyjlUI7zv2MsEjkEV8vtzkR9tpLlUpC20GH3C+eZHF3pXy7R5SuWnU6+6Ydlirsgd8J2bRTGHRNhwVU6TdB2NDBTQ10peOY7HePinQYjxN0Iv84fYXsP6Ay7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791046254; c=relaxed/simple; bh=rgmi8cN+SpzR1LZvYNcsfQI3YjDiUwkUJG5FRv+tXy8=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZaeBb0whch8Sk2cS5CmQ85XAUi0T9rS/OOxvD+wz2AbrYWuKyV4zKFPNxRkbRJdhQxfnetbbN0WP5Wl1p6ObehDsZH/DIl921n8FPSwAz5WQbcrEcHaxGFwA1NueAxV1LNAvhznslOUz32gnHuZLw740fJiMPj1ellGFeJpR5SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jgw5qt2x; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jgw5qt2x" Received: by mail-pj2-f13.google.com with SMTP id d9443c01a7336-2dd77300825so2162825ad.1 for ; Sat, 03 Oct 2026 09:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791046252; x=1791651052; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:from:to:cc:subject :date:message-id:reply-to:content-type; bh=o5nZhr5o/UkV60cwhqj+G+eK5fQZjsPv6PrbldXN5Gw=; b=jgw5qt2xQtANLaCSCmRTBi2JHZLY5CA9UEC0EUZ296TrPmMkmXoJNDMn/hlQITYX3W p3J0haqnVACBZngYnRd3ZjNJ3l1x8tTt71yB5L5DdvOlYDfdx0832kiO2o/qc1fvE1FH aALBLxk1vGfl+4byTAiqsLbdqXizqH1L45pbF1gbI2hxr71yooL/gPz6x/wTz0P2jJ2G ZW0hdEbtCJYyYy7j812Wka5gNOkP3clwR2iYdnnN+HqPy2q2jermruXXfD/a6hZT/EJM cTs1ANU9y3hH4EyqPyXVb/RU512RIVz3Df80Dt3pfSfJY4MkUncP1ati19IKuR3HtOBC wy3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791046252; x=1791651052; h=in-reply-to:content-disposition:content-type:mime-version :references:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o5nZhr5o/UkV60cwhqj+G+eK5fQZjsPv6PrbldXN5Gw=; b=blTcif0/wFXUZUn+V4KKhwGNNvoPphfZEBQ46AtswogzuKHdJ5mVFWnGip+3W8tFiv YKjrC7WT/af/IP0R/t9TqmVu8GjPGoBHPwR4qzaOrx73If0K7Hf6WyimLc2lhy0bghH5 sJ7HsU0y2JDTvx7RcZvk0ayOqE50ts/HRgiErqKpREk7+uU/WqhHtOAJbtvIDt6aVLbM 4pcAdZmN1e3dru2I7kEIewBq4jiM1Tl9Yog6tZvuGSKb2gY/9cPInHWFMrVz/bDWtIfQ TATovJiRPYzMk6gHpqFCdl7hKZxT2BY2fcEEY2gPLuAXwqOeZlNG8YYsbD1YOtnwB5yT GBaA== X-Forwarded-Encrypted: i=1; AKwUvBxWh7SNNauq7TXR+tGAaWlAHH51/vRQpgBAnCkU2M20yKPumXWs53/u5UyOD9JfLUZW5MHn1yYzKFSLWsCT3g==@vger.kernel.org X-Gm-Message-State: AFq9FYLKvV5lAjzVS29vSR8aVkqf5q2jDLPQ4oPGI7666pARc4Shn+gU O2TdqOen5spCSj/YbPOoWgkVh68fRgnGdwNNxLhLS5YhLf2OV4OkFdkLmTAB7g== X-Gm-Gg: AYBFou03nJH7TlaAqQ3w0I9Qkm44owSw27Np6tbK2+5RRnK2TZjwgeE6BoPn13bR6bK dAx3YU0JBTcg63fN4aPQg0DWqFLzzVs04HUg6/Odg0L8lfUj6Q8F7o1V9stCaW5FT8rHYv/DKvn oTqI3GdIWRbNw5m9Bt1Bn02OCc56a2ZvEM+JzXsynUyO7B/Or8H0u9Lvmbm3xbhv6MvkppOdyk1 6bHOqmHtqWdDm4i1UMUdYabuMG4JABmuPX2LegUhx2obO1uyHs9gEPaPWtc6y3DnbxjYfx2Q8EV 8xgkrT487pqSWeLfqsRbjE0fPjfaTKESZBvD7ZBzpEWV4quCCXWCsqQnx7PYfDeTg47eUhRZGGL VW0kLTxOLgaNcYl022OKJfUfldNJGPxc40EYUB05taTr8JoPvOL8JwQKUhqo+/kUMOS8YpiCQbh c+adcIOB7qmnDjiWpaJxjkYEFnc2U167khMonkLbIjp9h4JRdGpA9D5P3++LRh4768ZfHWZvcCx hFCBk/PsVumCKma3w== X-Received: by 2002:a17:902:cec4:b0:2dd:ad73:c93a with SMTP id d9443c01a7336-2e49b60bfa4mr53807145ad.27.1791046252208; Sat, 03 Oct 2026 09:50:52 -0700 (PDT) Received: from localhost (madb688426.ap.nuro.jp. [219.104.132.38]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e49f6d65bbsm18157495ad.54.2026.10.03.09.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2026 09:50:51 -0700 (PDT) Message-ID: <6ac1326b.0a67d0c9.2deb66.efb7@mx.google.com> X-Google-Original-Message-ID: <20261003165049.6hj23qszaetwiqu5@DESKTOP-1P5QNTF.> Date: Sun, 4 Oct 2026 01:50:49 +0900 From: Kohei Ito To: Linus Walleij Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?utf-8?B?w5Z6a2Fu?= , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/3] rust: gpio: add GPIO module with common definitions References: <20260906-add-rust-gpio-consumer-v1-0-24d192f93760@gmail.com> <20260906-add-rust-gpio-consumer-v1-1-24d192f93760@gmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Linus, thank you for your comments. > > Add the top-level GPIO module with minimal common definitions. This > > module is the basis for future Rust GPIO extensions. > > Describe what you want to enable by this patch. > > - Enabling in-kernel Rust code to use things from the > GPIO subsystem? (It looks like so.) > > - Writing GPIO drivers in rust? (It seems like not.) This patch is the first step to enable in-kernel Rust code to use things from the GPIO subsystem. I'll clarify this in the commit message. The patch series does not add Rust GPIO provider APIs or Rust GPIO provider drivers, but it is intended to be the basis for them. > > +/// Describes the raw GPIO level, i.e. the value of its physical line without regard for its > > +/// ACTIVE_LOW status. > > +#[derive(Clone, Copy, PartialEq, Eq)] > > +pub enum PhysicalLineLevel { > > No thanks. > > We want to hide the actual physical line level inside the > gpiolib (encapsulation). > > We should not expose the physical line level at all > unless there is a consumer in the kernel that absolutely > needs this, and there is none. Sure. I have no need to use the physical line level right now, so I'll remove it and the related definitions. Best regards, Kohei Ito