From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EE90140E5F for ; Thu, 11 Sep 2025 04:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757565973; cv=none; b=abAwWITIXpnyzlAzBUKVMSTU95QE5YEzZYj71Hd+OA6x/n0cjlGMR9WQPfaySfDLVJ6VY+y272WPCJ8N5j2uJHm/ZdGcLNS9arDz3hoRfIWrpoq2YrruDvU2TyBMhTOm33B1zquBKcki79cMjwLs800iyxQXTosY5kW9yrkXoH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757565973; c=relaxed/simple; bh=ZYQmQVPBF8zKRLNJ+D4bhiIq4DL1k5MFPT2Ve8g115I=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=RfFpn6h0p3WAN0YmOj0J9tZ/jvbeU0n5LywjG8fB5mbulDXSlGRMtxA+Pt2jd+8VcLVD1Q0wdiytYG5r3yJKOX2BivMH+W2HGeOpZKH4piy2Nf7gVXLGdoWAEQaDxZA3uW6CDkapW4E0YeqWuf6UiEiFIZ3Hde4aa3xOf9DLbsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QVUvX8H9; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QVUvX8H9" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-71d60528734so2519287b3.2 for ; Wed, 10 Sep 2025 21:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757565971; x=1758170771; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=1OFQORNmMyhF8NqnLlI7wxOYnlK/yXDebbJxZdkpHcc=; b=QVUvX8H99YU7pKHdlG0uydz/0HeW8qJ53/5dxsUs7PeTDkdQi08HUM3DSol7FAMrc1 QjvuOZ6McvDLrVzHOPstBnf2dM352XnRuaM+Oya5mh/EV3Dk1/YZtXvGgYXwV8N02Ptk mZ+cNc/0dGHSXwQHYM2lJEzl+2IN+h1eZWaQ+jMWNhkFrIaGbtI0msA0m8G9lG+MI/os nFSXEZFBWMwik4LSj2G2gh9/t/T4eSZwGZrr4LtyFCPJIuPvsC3rMo0Qq3CQXrvHD+QM ZJ+BBPZLAw+BWzNaBAR437h889AHD/XGanoQ7YJ197Ld1WVYEF+foVEuv+qK1jj3wiXp gp+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757565971; x=1758170771; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1OFQORNmMyhF8NqnLlI7wxOYnlK/yXDebbJxZdkpHcc=; b=cJcpI73yoMA+eCQBugeYeiH5pcalMqgwfH4MAeJqR+Q+lix1zNn0w7xyxhH1KUaqAG CQvQTinWeMCsQOqQ7XlhHVfJtOHSTe3qEi/XUWYEHkVHyMG95Cq2Vaz7cUqfVVZT8jLl jrLOEtzKZP+4uHC6eDgnHEeUet54K9ouNWmuCXZmCWpHRFs0KQjs0eSCcvvjb1kgGBc2 11OuYv29p3ZSblCKUcd8XPV0qZaKhekGWmRrbNOGNSJ+VXFrOJwuBV7tFZPGabxABrgv VB7FPQadDzD0mcIYQwtyBgk9oiLfldGpZAlJatkH6m5bI5bY7dm31NQ6sBAMSLvVvJZh oh5w== X-Forwarded-Encrypted: i=1; AJvYcCX+C+XZV8PvQbbKgBru67PYdaALvyO0jsuAj6DJoUpX+W00tf4aG/+TPsBPJwhTIKOJqA/EhMPFKeQgkWcqYA==@vger.kernel.org X-Gm-Message-State: AOJu0YzTkypfiWyawg/MAT3QHEXYD/LgbgF4DEFoMYf+K66eb1Wduh9R u5651AhJpySg2SDlfJYlIynSMW0FPqGAqJ4MxoFwZgPBZAFq3Wm0jEFn X-Gm-Gg: ASbGncsy2792vHMyQiPkR3QGfraJOHOOrjixOQmliwzk5NJ2X2YFtyFrYIdf2gn4IDS X8vMENOtffNUBRjpWJd5NOHAKJe2XULonHWzSmwkiPNdGLjnGDmfiTY+BBN9y/X2rVm0CfcM7M2 bRNt2pEWl1w3dT+xQs9HfT3B3BRULJmFPUZRk+cFHg5Rk4dQxIzyVSI8NYxfKz3pq3cRnCEGGqk hJuHGxNTeU3tp2WxpBRq/EmR4I3w23krfVk3mpPxOfuBSRfhR3ErCtGrom2q6oGkMUcr2aaBQTZ FaNbqtlko/C0Vd7ARuSrNhBobxY5ItZEfXZH59lpRdAOROyai6v+aml+NCRX4VHqYeH3TUVoGbH iFhEZZ4o3H9+TipBM/JMo0uErOPKGKBOnPU5LV4C8YMjt56B7b2+DUmM4FUt7VtPg5X0fxRCKKg == X-Google-Smtp-Source: AGHT+IE09XmvpU67NiXH7rk2LbrDMhUi3e2OWnnlWTn7trnF2NMGewy0hktXoxQgahi3Y4iKLHRnRg== X-Received: by 2002:a05:690c:6309:b0:722:7a7f:5358 with SMTP id 00721157ae682-727f28e7503mr153782967b3.4.1757565970388; Wed, 10 Sep 2025 21:46:10 -0700 (PDT) Received: from [192.168.1.209] (74.211.99.176.16clouds.com. [74.211.99.176]) by smtp.gmail.com with ESMTPSA id 00721157ae682-72f76c28400sm1130767b3.30.2025.09.10.21.46.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Sep 2025 21:46:09 -0700 (PDT) From: Asuna X-Google-Original-From: Asuna Message-ID: <6bceca9d-44cd-4373-a456-7c2129b418e3@gmail.com> Date: Thu, 11 Sep 2025 12:46:01 +0800 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] RISC-V: re-enable gcc + rust builds To: Conor Dooley Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Han Gao , rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev References: <20250909-gcc-rust-v2-v2-1-35e086b1b255@gmail.com> <20250910-harmless-bamboo-ebc94758fdad@spud> Content-Language: en-US In-Reply-To: <20250910-harmless-bamboo-ebc94758fdad@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/10/25 10:27 PM, Conor Dooley wrote: > FWIW, this --- breaks git, and anything after this line (including your > signoff) is lost when the patch is applied. I used b4 command to prepare and send the cover letter and patch for v2, not sure what happened. I see that other people's patches have a [PATCH 0/n] email as a start that describes their patch series, this is called a cover-letter in b4 and git-send-email right? > The riscv patchwork CI stuff is really unhappy with this change: > init/Kconfig:87: syntax error > init/Kconfig:87: invalid statement > init/Kconfig:88: invalid statement > init/Kconfig:89:warning: ignoring unsupported character '`' > init/Kconfig:89:warning: ignoring unsupported character '`' > init/Kconfig:89:warning: ignoring unsupported character '.' > init/Kconfig:89: unknown statement "This" > > Is this bogus, or can rustc-bindgen-libclang-version return nothing > under some conditions where rust is not available? > Should this have 2 default lines like some other options in the file? This is because rustc-bindgen-libclang-version can't find the bindgen and returns nothing. Sorry I forgot to mention this, it's another reason why I wanted to separate the script, in a separate script we can easily fallback to return 0 when an error is encountered. Adding a second line `default 0` doesn't work, I'll try to fix it. BTW, when I fix it, if the diff isn't too large, do I need to open a v3 patch, or simply replying to the thread just fine?