Re: [PATCH 1/2] rust: kernel: init: replace unwraps with the question mark operators

[Dirk Behme <dirk.behme@gmail.com>]

Hi Daniel,

On 16.11.24 20:46, Daniel Sedlak wrote:
> Link: https://lore.kernel.org/rust-for-linux/CANiq72nsK1D4NuQ1U7NqMWoYjXkqQSj4QuUEL98OmFbq022Z9A@mail.gmail.com/


While talking about that thread, do you like to cover the dox()
replacement

https://lore.kernel.org/rust-for-linux/459782fe-afca-4fe6-8ffb-ba7c7886de0a@de.bosch.com/

as well?

Thanks for working on this! :)

Dirk


> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Daniel Sedlak <daniel@sedlak.dev>
> ---
>  rust/kernel/init.rs | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs
> index 347049df556b..81d69d22090c 100644
> --- a/rust/kernel/init.rs
> +++ b/rust/kernel/init.rs
> @@ -1076,8 +1076,9 @@ pub fn uninit<T, E>() -> impl Init<MaybeUninit<T>, E> {
>  /// ```rust
>  /// use kernel::{alloc::KBox, error::Error, init::init_array_from_fn};
>  /// let array: KBox<[usize; 1_000]> =
> -///     KBox::init::<Error>(init_array_from_fn(|i| i), GFP_KERNEL).unwrap();
> +///     KBox::init::<Error>(init_array_from_fn(|i| i), GFP_KERNEL)?;
>  /// assert_eq!(array.len(), 1_000);
> +/// # Ok::<(), Error>(())
>  /// ```
>  pub fn init_array_from_fn<I, const N: usize, T, E>(
>      mut make_init: impl FnMut(usize) -> I,
> @@ -1120,8 +1121,9 @@ pub fn init_array_from_fn<I, const N: usize, T, E>(
>  /// ```rust
>  /// use kernel::{sync::{Arc, Mutex}, init::pin_init_array_from_fn, new_mutex};
>  /// let array: Arc<[Mutex<usize>; 1_000]> =
> -///     Arc::pin_init(pin_init_array_from_fn(|i| new_mutex!(i)), GFP_KERNEL).unwrap();
> +///     Arc::pin_init(pin_init_array_from_fn(|i| new_mutex!(i)), GFP_KERNEL)?;
>  /// assert_eq!(array.len(), 1_000);
> +/// # Ok::<(), Error>(())
>  /// ```
>  pub fn pin_init_array_from_fn<I, const N: usize, T, E>(
>      mut make_init: impl FnMut(usize) -> I,