Re: [RFC 07/16] bus1: add man-page

["David Rheinsberg" <david@readahead.eu>]

Hi,

I missed this, sorry!

On Sat, Apr 11, 2026, at 2:46 PM, Thomas Meyer wrote:
> I did write a small test program, that creates handles in a loop till it gets
> an error from the OS, and run it against the code from your wip/bus1 branch on
> github/bus1/linux. The creation of handles itself doesn't seems to get
> accounted. If you like I can upload this little test program somewhere.

Oh my, I did not hook up the accounting. Will do so! Your changes look good!

Thanks
David

> commit aa0b3987801e8ea773254badcd17b73ae140dbf2
> Author: Thomas Meyer <thomas@m3y3r.de>
> Date:   Sat Apr 11 14:06:47 2026 +0200
>
>     bus1: charge handles and fix unlink
>
> diff --git a/ipc/bus1/bus.rs b/ipc/bus1/bus.rs
> index 70a6a4f35d96e..e5222fdb931a7 100644
> --- a/ipc/bus1/bus.rs
> +++ b/ipc/bus1/bus.rs
> @@ -20,6 +20,7 @@ enum MessageError {
>  #[pin_data]
>  struct Peer {
>      actor: Arc<acct::Actor>,
> +    charge: acct::Charge,
>      waitq: *mut kernel::bindings::wait_queue_head,
>      queue: lll::List<TxNodeRef>,
>      queue_committed: atomic::Atomic<usize>,
> @@ -36,6 +37,7 @@ struct PeerLocked {
>  #[pin_data]
>  struct Node {
>      owner: Arc<Peer>,
> +    charge: acct::Charge,
>      userdata: atomic::Atomic<usize>,
>      op_rb: rb::Node,
>      #[pin]
> @@ -124,10 +126,15 @@ fn new(
>          actor: Arc<acct::Actor>,
>          waitq: *mut kernel::bindings::wait_queue_head,
>      ) -> Result<Arc<Self>, AllocError> {
> +        let charge = actor.as_arc_borrow().charge(
> +            actor.as_arc_borrow(),
> +            &[1, core::mem::size_of::<Self>() as u64],
> +        ).map_err(|_| AllocError)?;
>          let tx = Tx::new()?;
>          match Arc::pin_init(
>              pin_init!(Self {
>                  actor,
> +                charge,
>                  waitq,
>                  queue: lll::List::new(),
>                  queue_committed: atomic::Atomic::new(0),
> @@ -381,9 +388,14 @@ impl Node {
>      fn new(
>          owner: Arc<Peer>,
>      ) -> Result<Arc<Self>, AllocError> {
> +        let charge = owner.actor.as_arc_borrow().charge(
> +            owner.actor.as_arc_borrow(),
> +            &[1, core::mem::size_of::<Self>() as u64],
> +        ).map_err(|_| AllocError)?;
>          match Arc::pin_init(
>              pin_init!(Self {
>                  owner,
> +                charge,
>                  userdata: atomic::Atomic::new(0),
>                  op_rb: rb::Node::new(),
>                  inner <- kernel::sync::new_mutex!(
> @@ -470,6 +482,10 @@ fn new(
>          node: Arc<Node>,
>          owner: Arc<Peer>,
>      ) -> Result<Arc<Handle>, AllocError> {
> +        let _charge = owner.actor.as_arc_borrow().charge(
> +            owner.actor.as_arc_borrow(),
> +            &[1, core::mem::size_of::<Self>() as u64],
> +        ).map_err(|_| AllocError)?;
>          Arc::new(
>              Self {
>                  node,
> @@ -803,12 +819,10 @@ fn commit(self: Pin<&mut Self>) {
>              let txnode = TxNodeRef::new_release_handle(h.clone());
>              if let Err(_) = to.queue.try_link_front(txnode) {
>                  kernel::warn_on!(true);
> -                c.try_unlink_and_move_next();
> -                continue;
>              }
> 
>              h.as_arc_borrow().unlink();
> -            c.move_next();
> +            c.try_unlink_and_move_next();
>          }
> 
>          // Step #2