From: John Hubbard <jhubbard@nvidia.com>
To: "Mitchell Levy" <levymitchell0@gmail.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] rust: cpumask: Bindings for core cpumasks and cpumask iterators
Date: Wed, 5 Nov 2025 16:19:36 -0800 [thread overview]
Message-ID: <7107432f-4d0f-4544-9592-76a5e5c6d220@nvidia.com> (raw)
In-Reply-To: <20251105-cpumask-iter-v1-0-7536f906d7ed@gmail.com>
On 11/5/25 3:16 PM, Mitchell Levy wrote:
> The kernel provides a number of very useful CPU masks from the C side,
> including CPU masks for possible and online CPUs. In particular, these
> are very useful when some operation must be done on each CPU (either
> each possible CPU or each online CPU, etc). Therefore, it seems to make
> sense to add both of these functionalities at once.
>
> Signed-off-by: Mitchell Levy <levymitchell0@gmail.com>
> ---
> These patches originated as part of my work on a Rust per-CPU API [1].
> Boqun suggested to me that these may make sense to merge separately, and
> it does seem like these might be useful beyond the per-CPU work.
>
> [1]: https://lore.kernel.org/rust-for-linux/20251105-rust-percpu-v4-0-984b1470adcb@gmail.com/
Even though you are trying to get these two patches merged separately,
I think it's best (for reviewers) if you post a patchset that shows
these things being used. Otherwise it is potentially too unmoored from
reality, and hard to be sure that it's exactly right from a caller's
point of view.
In this case, just posting that 9-patch series might work, and just
say in the cover letter that patches 3 through 9 are not ready for
merging.
Something like that.
I realize that Rust for Linux is being built from scratch right
now, but including calling code in a patchset is a really valuable
kernel convention that helps validate the code.
I say this for the benefit of others who may be reading. :)
thanks,
--
John Hubbard
next prev parent reply other threads:[~2025-11-06 0:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 23:16 [PATCH 0/2] rust: cpumask: Bindings for core cpumasks and cpumask iterators Mitchell Levy
2025-11-05 23:16 ` [PATCH 1/2] rust: cpumask: Add a `Cpumask` iterator Mitchell Levy
2025-11-05 23:16 ` [PATCH 2/2] rust: cpumask: Add getters for globally defined cpumasks Mitchell Levy
2025-11-06 0:19 ` John Hubbard [this message]
2025-11-07 1:38 ` [PATCH 0/2] rust: cpumask: Bindings for core cpumasks and cpumask iterators Yury Norov
2025-11-07 23:56 ` Mitchell Levy
2025-11-08 3:30 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7107432f-4d0f-4544-9592-76a5e5c6d220@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=levymitchell0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox