From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C05145A0F; Thu, 28 Nov 2024 14:06:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732802792; cv=pass; b=VQ3hGBi5zGp9Eh0v/vgTXc7hnqyOPvig1cvq4BKMhRz+FjBoLBJc3aUepnVrlHDjUir0ObM6Pvv/dNlVSas9345RGYUl66wHLd8Mmevg3wjTp7qNmByUf3VHboaVtfOdSsrsfrW0EBPhAYRjyZ4vRkCGRltmZGEZF3CpWyAgcko= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732802792; c=relaxed/simple; bh=lsaXY0lxZ1zQ82A8+HONtt9jHRlMVWP7xWcLVF8MNc0=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=EEgezQS4pzjIhBqyiNAwPYqJ5tkIrNzxuZcTlp+0362Daa2Qy4Qn9nwCZ7z70oX6da5AKkVUOmCQU86Nq9oQH/GHMSFpgK9LWZT2nTxoh8Euet3tDqYwEWDg2xTYBVgD4seKc9TqaXWRGDiUuFlOrMxv4FYWlbT/GoxiZBhvIOY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=a+xmRzSf; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="a+xmRzSf" ARC-Seal: i=1; a=rsa-sha256; t=1732802758; cv=none; d=zohomail.com; s=zohoarc; b=oB//s39QD9RHwyTMru2LK6OxjrFwNKSF7XbsDQVNF8392OY9K2eEVYsZFCcYCLlMldp6NRHc2oKeNApeeqficbEXbYLlZA8twmf77SDF5WZcSM9Kgt4KKSNySSXFePa+MG7pXITXMEp2H65L3BVRMYYzJa4bFm6LmY+hkrrcZuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732802758; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5zUEiPJ5HRZWwfzDbLTtNuHqL6gztak6PTx5iUX6B3s=; b=ERj6d3tFnh8OpeA/3lAMDt3AFLLJRk8JAEEGjD4SjdgdzwWO5ZYV07VbS8zFo1TeTEivwz4TBCIFv5sLBNAWySriBRl64BnipT31jetZCo7FPQesIIiAlZ5sW+Lmuw4dByPtGVQxIpBF+1cUaGgKQGwFj/dedVhgevVCtw1vGuM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1732802758; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=5zUEiPJ5HRZWwfzDbLTtNuHqL6gztak6PTx5iUX6B3s=; b=a+xmRzSfuV9rujTdieN91apxAv1xzj3RnZT7+Y1E6LekhFWgLwd3AqBhcmUU0prr 5VmLTeMm+SoPzY+LMP9Tg5Lp59BryLh7tSSz+PcoMr8jcrYh6PSMkGkv6qqTFXtp5+H 4Y0hvVXiGH86ZMpzR1kzJrGGSo+HeSQfzyk+lRFE= Received: by mx.zohomail.com with SMTPS id 1732802756921356.23851212628585; Thu, 28 Nov 2024 06:05:56 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [WIP RFC v2 26/35] WIP: rust: drm/kms: Add RawPlaneState::atomic_helper_check() From: Daniel Almeida In-Reply-To: <20240930233257.1189730-27-lyude@redhat.com> Date: Thu, 28 Nov 2024 11:04:24 -0300 Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Asahi Lina , Danilo Krummrich , mcanal@igalia.com, airlied@redhat.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , open list Content-Transfer-Encoding: quoted-printable Message-Id: <7148C7F5-6412-44CB-B92A-4ABAE4A4D5C3@collabora.com> References: <20240930233257.1189730-1-lyude@redhat.com> <20240930233257.1189730-27-lyude@redhat.com> To: Lyude Paul X-Mailer: Apple Mail (2.3826.200.121) X-ZohoMailClient: External Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: >=20 > Add a binding for drm_atomic_helper_check_plane_state(). Since we want = to > make sure that the user is passing in the new state for a Crtc instead = of > an old state, we explicitly ask for a reference to a = BorrowedCrtcState. >=20 > Signed-off-by: Lyude Paul >=20 > --- >=20 > TODO: > * Add support for scaling options Can / should this be a separate commit? This would allow this one to go = in earlier. >=20 > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/kms/plane.rs | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) >=20 > diff --git a/rust/kernel/drm/kms/plane.rs = b/rust/kernel/drm/kms/plane.rs > index 4d16d53179fca..cd5167e6441f1 100644 > --- a/rust/kernel/drm/kms/plane.rs > +++ b/rust/kernel/drm/kms/plane.rs > @@ -496,6 +496,31 @@ fn crtc<'a, 'b: 'a>(&'a self) -> Option<&'b = OpaqueCrtc< // SAFETY: This cast is guaranteed safe by `OpaqueCrtc`s = invariants. > NonNull::new(self.as_raw().crtc).map(|c| unsafe { = OpaqueCrtc::from_raw(c.as_ptr()) }) > } > + > + /// Run the atomic check helper for this plane and the given CRTC = state > + fn atomic_helper_check( > + &mut self, > + crtc_state: &BorrowedCrtcState<'_, S>, > + can_position: bool, > + can_update_disabled: bool > + ) -> Result Some docs on the arguments would be nice IMHO. Things like = `can_position` and `can_update_disabled` seem a bit opaque. > + where > + S: FromRawCrtcState, > + S::Crtc: AsRawCrtc::Driver> > + { > + // SAFETY: We're passing the mutable reference from = `self.as_raw_mut()` directly to DRM, > + // which is safe. > + to_result(unsafe { > + bindings::drm_atomic_helper_check_plane_state( > + self.as_raw_mut(), > + crtc_state.as_raw(), > + bindings::DRM_PLANE_NO_SCALING as _, // TODO: add = parameters for scaling > + bindings::DRM_PLANE_NO_SCALING as _, No scaling means that you can only select the display=E2=80=99s highest = resolution? > + can_position, > + can_update_disabled > + ) > + }) > + } > } > impl RawPlaneState for T {} >=20 > --=20 > 2.46.1 >=20 Barring the comment above about the docs, this looks good. =E2=80=94 Daniel