From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Qingsong Chen <changxian.cqs@antgroup.com>, linux-kernel@vger.kernel.org
Cc: 田洪亮 <tate.thl@antgroup.com>, "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Sergio González Collado" <sergio.collado@gmail.com>,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`
Date: Mon, 26 Jun 2023 13:49:35 -0300 [thread overview]
Message-ID: <743b4c1f-6c46-6d5d-24e9-b286d021389b@gmail.com> (raw)
In-Reply-To: <20230626074242.3945398-2-changxian.cqs@antgroup.com>
On 6/26/23 04:42, Qingsong Chen wrote:
> If the trait has same function name, the `vtable` macro
> will redefine its `gen_const_name`, e.g.:
> ```rust
> #[vtable]
> pub trait Foo {
> #[cfg(CONFIG_X)]
> fn bar();
>
> #[cfg(not(CONFIG_X))]
> fn bar(x: usize);
> }
> ```
> Use `HashSet` to avoid this.
>
> Signed-off-by: Qingsong Chen <changxian.cqs@antgroup.com>
> ---
> [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-06-26 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 7:42 [PATCH 0/1] Fix redefine const_name in `vtable` macro Qingsong Chen
2023-06-26 7:42 ` [PATCH 1/1] rust: macros: fix redefine const_name in `vtable` Qingsong Chen
2023-06-26 16:49 ` Martin Rodriguez Reboredo [this message]
2023-06-28 9:59 ` Benno Lossin
2023-06-28 16:42 ` Gary Guo
2023-08-02 17:39 ` Miguel Ojeda
2023-08-02 17:43 ` Miguel Ojeda
2023-08-02 19:50 ` Alice Ryhl
2023-08-02 20:02 ` Gary Guo
2023-08-03 9:20 ` Qingsong Chen
2023-08-03 12:52 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743b4c1f-6c46-6d5d-24e9-b286d021389b@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=changxian.cqs@antgroup.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sergio.collado@gmail.com \
--cc=tate.thl@antgroup.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).