From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 184553B8412 for ; Mon, 3 Aug 2026 09:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785747684; cv=none; b=cA+9YXW3G8Jy0/5Z1LiXcgHMtxMYZPFetWjkcBf/HYwqPwL6X7relYEyPxARJzR7z1lN7B/j7+Tx5fn3fyfV4YGGZrrAJBJbcIUqFsXTztx8gEJQn/1IQXBnm/+5U7KhwguFnaL76Dd5JtQ+fY1phF6qslPoiLRE1mmw9Q8yAEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785747684; c=relaxed/simple; bh=A6jrGJQtDJIL30mxb3XxVFNiY/hbrxZT0aR9eyUYw4A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ip+xhhgxDAeO2exaK7bD/B0un+Mgye/xx+p8CPpynDEufxHhLHwBbnH8CBFWYWCZnJ/4axr6FbdOYTVsMbGfC2E4reXE31V9vOJbRgKEN3jqAhi15dejDwiPfbt0Pa0X/LtUOdhxCEAuG07sS2xxl7YKhYSQUz2KVojNxmLuoXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dXmt8Plc; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dXmt8Plc" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47f96c5b722so1801046f8f.0 for ; Mon, 03 Aug 2026 02:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785747677; x=1786352477; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7c8ajU7Bc5fO7IMCQU0cwsLx5uJDTGm1qTHU9/J8vs4=; b=dXmt8Plc4V8OFjKUyT1OcliVle3n2TVjN0Vu2NntFGVmm51aEyF1EyTQr6tGG/s8Dd UX4qnmfCUOJa9Y4heC1+/lbLnntTZcGrz+3Tk3cL/EMbA21G5H0J0YRi/2ZADaOIagRv O4js0Qd1wgFT79ID7AmY8ubZhbm3jqMw8JHg8/gsXcUOkKm1SdSoH0BRT2YObncQzny9 QqDGtNlURng41GZHIXh4Ke3IY1pd/wGsViVzZXCMIgbQkK3ccLsivVGnA0VqhQo99Lxc KId99/VBnGAYIEoKC4Bv62PO8tDdCiGzYZmOPqU0BjNx7Ra2v96fDoHv3IhVU5GI6InB GREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785747677; x=1786352477; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7c8ajU7Bc5fO7IMCQU0cwsLx5uJDTGm1qTHU9/J8vs4=; b=coPbUHPjo549RNubX016HQimCP9FeWTtQ4PfVfmSvU7tN254ektIv97uz50JhcAm36 xLer/jRYunJkR0O5Md5L4jom1YjEZNSG269e/UK9/6wa8LNT3xq0l/8FF2kVDcD+eRWb Rk3EclTSbxmqr+r/XlmYDST5+b9Bz8dWNP8fhhDr0N3I1+xPqHZQ7Sd29fwIaEc3n4A0 fO61dlvrCiQ3idrrlRQhvjTmba8k9Zq2MQUNlRUhhvzDmHNEYnKhl/2DX+lvFS6UtelS DwXlQDwuAAlETbaq6ku1FAGXBlNFWyLvTMVLg3xljzrhAwh02+/+IKKsYjCYhxcBCGC4 jYng== X-Forwarded-Encrypted: i=1; AHgh+RoxmG/3orJVJz52Awbg4hw8H8Tgbvrnjo/ifF2O6mF9yVxUginnAT4xwgFIaimr5ud4PoK01SnOP2t4u5VEMg==@vger.kernel.org X-Gm-Message-State: AOJu0Yw34bQJg38vidMWXGfuTJDG9nZfWcTn02kA0wKZcfsQOH6K9fTK 5nIU4X0rRU0pfswhWwrYX5zYVrakLNGoQxCTdIDhwpkwEDg/QM11LEJsFJtIJ7zmNSQ= X-Gm-Gg: AR+sD13lQ63Iur2Wj2/uJV+8VYprBH2wanHwZAbQRQc9xXXAyYgO2d9F3mOcG1vUWXv QvoCiKFb3Qf5RF2mOcWdINP1yl9WGvBqnUN//1+dHPbSFjiDaLwRRG4WAR1i66XoQhvMRAohB1C Zyz9MCFWwrq1yU7frRNAKDvYlU9hqn2Z32urdLM2pss83QoUajo3rYbiNDeLnBLflS48IFkGsid SC51VO2lFy4QhPGNtM6tcaPsUbt9vUKiLgfj83fXzZ1LNxyW+uctUZSdnUsXu3wPKw2JtGi1Jsv m48C5HD6X3MLTlMSaorUsfCug9NFa3b7cmD3ZGUXV3doRmkiqhQ4BU8Q0b0hKWnbfj77nuhlQTA YUxKoY6F1SqE/utL4Ue6L9udnLWjEH31+jtIR2JTMeznB5GLzeChQDdMxeiCzTXn79Hgdvos1eG KqUVAFc0tFnrFTP/pgWTJQdPHEt29nVxt4y1AlzqBhKjYft++67HsJqtxoHvjm8LCCPSCCNfDDh LspJF/MPj2da6GJLHM3+PLQJ1uJUmsUgFp3OBJrhzavIupCZfCsNNAvV8Z+jvZ7una/axTENKWW y4SZ7/hSNACp0jRvzvOQpcyPylgj3cc= X-Received: by 2002:a05:6000:481c:b0:47f:8ac0:ccd3 with SMTP id ffacd0b85a97d-47fd9fa5e61mr20758749f8f.2.1785747677195; Mon, 03 Aug 2026 02:01:17 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd458b73asm29125053f8f.29.2026.08.03.02.01.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 02:01:16 -0700 (PDT) Message-ID: <7b24e554-0f13-40fb-bc04-dd64cdb93528@suse.com> Date: Mon, 3 Aug 2026 11:01:14 +0200 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 09/10] rust: macros: remove `THIS_MODULE` static from `module!` To: Alvin Sun Cc: Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Greg Kroah-Hartman , "Rafael J. Wysocki" , David Airlie , Simona Vetter , Daniel Almeida , Arnd Bergmann , Brendan Higgins , David Gow , Rae Moar , Breno Leitao , Jens Axboe , Dave Ertman , Leon Romanovsky , Igor Korotin , FUJITA Tomonori , Bjorn Helgaas , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas , rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org, driver-core@lists.linux.dev, dri-devel@lists.freedesktop.org, nova-gpu@lists.linux.dev, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org References: <20260723-fix-fops-owner-v9-0-c1c3af7f7bcb@linux.dev> <20260723-fix-fops-owner-v9-9-c1c3af7f7bcb@linux.dev> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260723-fix-fops-owner-v9-9-c1c3af7f7bcb@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/23/26 4:10 AM, Alvin Sun wrote: > All users have been migrated to `ModuleMetadata::THIS_MODULE` const or > `this_module::()` helper. The `static THIS_MODULE` > generated by the `module!` macro is no longer referenced anywhere, > so remove it to avoid having two sources of the same `ThisModule` > pointer. > > Assisted-by: opencode:glm-5.2 > Reviewed-by: Andreas Hindborg > Reviewed-by: Gary Guo > Acked-by: Danilo Krummrich > Reviewed-by: Alice Ryhl > Signed-off-by: Alvin Sun Acked-by: Petr Pavlu > --- > rust/macros/module.rs | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/rust/macros/module.rs b/rust/macros/module.rs > index aa9a618d5d19e..23b6a1b456b80 100644 > --- a/rust/macros/module.rs > +++ b/rust/macros/module.rs > @@ -497,22 +497,6 @@ pub(crate) fn module(info: ModuleInfo) -> Result { > /// Used by the printing macros, e.g. [`info!`]. > const __LOG_PREFIX: &[u8] = #name_cstr.to_bytes_with_nul(); > > - // SAFETY: `__this_module` is constructed by the kernel at load time and will not be > - // freed until the module is unloaded. > - #[cfg(MODULE)] > - static THIS_MODULE: ::kernel::ThisModule = unsafe { > - extern "C" { > - static __this_module: ::kernel::types::Opaque<::kernel::bindings::module>; > - }; > - > - ::kernel::ThisModule::from_ptr(__this_module.get()) > - }; > - > - #[cfg(not(MODULE))] > - static THIS_MODULE: ::kernel::ThisModule = unsafe { > - ::kernel::ThisModule::from_ptr(::core::ptr::null_mut()) > - }; > - > /// The `LocalModule` type is the type of the module created by `module!`, > /// `module_pci_driver!`, `module_platform_driver!`, etc. > type LocalModule = #type_; >