Re: [PATCH 2/3] rust: task: implement == operator for Task

[Gary Guo <gary@garyguo.net>]

On 2026-02-19 13:52, Alice Ryhl wrote:
> It's useful to compare if two tasks are the same task or not. Rust
> Binder wants this to check if a certain task is equal to the group
> leader of current.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
>  rust/kernel/task.rs | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/rust/kernel/task.rs b/rust/kernel/task.rs
> index 
> cc907fb531bceea6e8dc1175d9350bd24780a3d5..8834bf25cce5e7b7f48cd649c977eb92fbfb61e9 
> 100644
> --- a/rust/kernel/task.rs
> +++ b/rust/kernel/task.rs
> @@ -362,6 +362,14 @@ unsafe fn dec_ref(obj: ptr::NonNull<Self>) {
>      }
>  }
> 
> +impl PartialEq for Task {

Missing `#[inline]`. With this fixed:

Reviewed-by: Gary Guo <gary@garyguo.net>

> +    fn eq(&self, other: &Self) -> bool {
> +        ptr::eq(self.as_ptr(), other.as_ptr())
> +    }
> +}
> +
> +impl Eq for Task {}
> +
>  impl Kuid {
>      /// Get the current euid.
>      #[inline]