Re: [PATCH v8 2/2] platform: Add initial synology microp driver

[Markus Probst <markus.probst@posteo.de>]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

On Tue, 2026-04-21 at 17:33 +0200, Krzysztof Kozlowski wrote:
> On 20/04/2026 16:24, Markus Probst wrote:
> > +        // pineview
> > +        (DeviceId::new(c"synology,ds710p-microp"), Model::new().led_esata()),
> > +        (DeviceId::new(c"synology,ds1010p-microp"), Model::new().led_alert(Color::Orange)),
> > +        (DeviceId::new(c"synology,ds411p-microp"), Model::new()),
> > +
> > +        // r1000
> > +        (DeviceId::new(c"synology,ds923p-microp"), Model::new()),
> > +        (DeviceId::new(c"synology,ds723p-microp"), Model::new()),
> > +        (DeviceId::new(c"synology,ds1522p-microp"), Model::new()),
> 
> What is this all doing here? Again, what is the fallback and front
> compatible?
> 
See previous comment. There was no separation between them until now. I
will fix that.

> Why do you keep duplicating all this when I asked to REMOVE
> the completely unnecessary front compatibles?
I can't recall you asking that. My apologies if I missed that.

So only keep the fallbacks and only add a front compatible if a
unexpected difference comes up?

Thanks
- Markus Probst

> 
> So it is not only schema which is wrong, but your driver makes no sense
> with it.
> 
> Best regards,
> Krzysztof

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 870 bytes --]