From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77D39481B1 for ; Mon, 17 Mar 2025 01:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742174859; cv=none; b=oKyRfjaBI//DYbMhNJuKVWaUAd0CoIjj8tiER3ssg+o114uQPeX+m4ADkS7Zz43j047mGSxIRkkWAezBgv7U2+ZYc99mYmjVI+xr5i7ZgrUjM38jRUq9NnWUR2AtmRne28/yfG7/+TIQBcUwBHHF58ExAQEqo2ekgC9GJ7uflJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742174859; c=relaxed/simple; bh=t+bHbAqt0/x0swFV522Yl4VosXMAhw6VzZ3OgIf3mmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jXVwhfqCggtos/vkp6znf6RxRXAXxz3x5/lYDcLMsSKCxEjbdMDDt0Sepzp5Dkrwoo0Ph9t0GBmPhfsYX7pb4hZ9IW55t2lqhwqsLzQ/kz4usT2f34dc1Ys4RwYqVh88DSxlPGq0xH3FeJi9p+xrMzDe6w7BNfrm7H1kqTALd90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Zj5It0Pj; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Zj5It0Pj" Message-ID: <7c949bef-1957-4a1d-b75f-9f642f8c848d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742174845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rjk2EB6B1VDjQml7YtpwBw8uSvBgCyIRa4CuzWf9SSI=; b=Zj5It0PjSwe+CJGBHr97bwnRtv6tZUz9TgUtP5Adc1iau/NRZ5gG6tIzufHjMMqrJL8iiB Opo4o8t6O+eQX3tCU5feCYqB2fdzwyUS1Sypf9Eo0fZzFsfpOPJuCvlAtuHDdBfLH9C8vE sOseEcnIOAvrAAowNsPOhdcA3otIFZA= Date: Mon, 17 Mar 2025 09:26:32 +0800 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] rust: file: optimize rust symbol generation for FileDescriptorReservation Content-Language: en-US To: Alice Ryhl Cc: ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, tmgross@umich.edu, dakr@kernel.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Kunwu Chan , Grace Deng References: <20250313084525.773620-1-kunwu.chan@linux.dev> <6c874a4f-439e-4ab2-807d-d0f59b9fe569@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kunwu Chan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 2025/3/14 17:21, Alice Ryhl wrote: > On Fri, Mar 14, 2025 at 3:34 AM Kunwu Chan wrote: >>> * I think it is easier to read the symbols if you list each sybmol on >>> one line like this: >>> >>> ffff8000805b6ef0 T ::fd_install >>> ffff8000805b6e60 T ::get_unused_fd_flags >>> ffff8000805b6f08 T ::drop >> If in one line, checkpatch.pl will report a warning: >> >> WARNING:Prefer a maximum 75 chars per line (possible unwrapped commit >> description?) >> >> If no need to bother with the warning, I'll change it to one line in v2. > You could do this: > ... T ::fd_install > but if it's still too long I'd just ignore it. Thanks, I'll change it in v2. > > Alice -- Thanks, Kunwu.Chan