From: Alice Ryhl <alice@ryhl.io>
To: Ben Gooding <ben.gooding.dev@gmail.com>
Cc: "Benno Lossin" <benno.lossin@proton.me>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Martin Rodriguez Reboredo" <yakoyoku@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: lock: Add intra-doc links to the Backend trait
Date: Sun, 7 May 2023 17:29:08 +0200 [thread overview]
Message-ID: <7f464c01-d4ec-d632-fa40-0c3f18c2ffca@ryhl.io> (raw)
In-Reply-To: <20230507152232.803-1-ben.gooding.dev@gmail.com>
On 5/7/23 17:22, Ben Gooding wrote:
> Also fix a minor typo in one of the comments
>
> Suggested-by: Benno Lossin <benno.lossin@proton.me>
> Link: https://lore.kernel.org/rust-for-linux/94625fe6-b87a-a8f0-5b2a-a8152d5f7436@proton.me/
> Link: https://github.com/Rust-for-Linux/linux/issues/1001
> Signed-off-by: Ben Gooding <ben.gooding.dev@gmail.com>
> ---
> -/// Exposes one of the kernel locking primitives. Which one is exposed depends on the lock backend
> +/// Exposes one of the kernel locking primitives. Which one is exposed depends on the lock [backend](Backend)
This line is too long. Please reflow at 100 characters.
You can also consider this option:
/// Exposes one of the kernel locking primitives. Which one is exposed
depends on the lock [backend]
/// specified as the generic parameter `B`.
///
/// [backend]: Backend
next prev parent reply other threads:[~2023-05-07 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 15:22 [PATCH] rust: lock: Add intra-doc links to the Backend trait Ben Gooding
2023-05-07 15:29 ` Alice Ryhl [this message]
2023-05-07 16:27 ` [PATCH] rust: lock: Reflow long documentation line Ben Gooding
2023-05-08 20:37 ` Miguel Ojeda
2023-05-09 20:39 ` Ben Gooding
2023-05-08 20:54 ` [PATCH] rust: lock: Add intra-doc links to the Backend trait Miguel Ojeda
2023-05-09 20:23 ` [PATCH v2] " Ben Gooding
2023-07-19 19:59 ` Miguel Ojeda
2023-05-15 17:59 ` [PATCH] " Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f464c01-d4ec-d632-fa40-0c3f18c2ffca@ryhl.io \
--to=alice@ryhl.io \
--cc=alex.gaynor@gmail.com \
--cc=ben.gooding.dev@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
--cc=yakoyoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).