Re: [PATCH net-next v4 6/6] net: phy: add Applied Micro QT2025 PHY driver

[Benno Lossin <benno.lossin@proton.me>]

On 17.08.24 20:51, Andrew Lunn wrote:
>> +    fn read_status(dev: &mut phy::Device) -> Result<u16> {
>> +        dev.genphy_read_status::<C45>()
>> +    }
> 
> Probably a dumb Rust question. Shouldn't this have a ? at the end? It
> can return a negative error code.

`read_status` returns a `Result<u16>` and `Device::genphy_read_status`
also returns a `Result<u16>`. In the function body we just delegate to
the latter, so no `?` is needed. We just return the entire result.

Here is the equivalent pseudo-C code:

    int genphy_read_status(struct phy_device *dev);
    
    int read_status(struct phy_device *dev)
    {
        return genphy_read_status(dev);
    }

There you also don't need an if for the negative error code, since it's
just propagated.

Hope this helps!

---
Cheers,
Benno