Re: [RFC PATCH v4 0/2] net::phy add unified API for C22 and C45 registers

[Benno Lossin <benno.lossin@proton.me>]

On 07.06.24 07:21, FUJITA Tomonori wrote:
> add unified API for C22 and C45, reading/writing registers and
> genphy_read_status().
> 
> We could add methods specifically C45 like read/write_c45 and
> genphy_c45_read_status. Instead, this implements the unified API for
> C22 and C45 with a new reg module.
> 
> v4:
> - make reg module sealed
> - improve the comments
> - add examples
> - use error::to_result() to simplify some functions
> v3: https://lore.kernel.org/all/20240603.233954.1644803151268035787.fujita.tomonori@gmail.com/T/
> - move reg module to a new file (with MAINTAINERS updated)
> - rewrite commit log and subjects
> - rename Access trait to Register
> - add build error message for build_assert!
> - define the complete MMD list
> - drop new func for Mmd
> - remove trait GenPhyOps
> v2: https://lore.kernel.org/all/20240601043535.53545-2-fujita.tomonori@gmail.com/T/
> - add genphy helper support and split the patch
> - create a 'reg' module
> - define C22 according to the specs
> - handle C22 vendor specific registers
> - add const for C45 MMD
> v1: https://lore.kernel.org/all/20240530.145258.456915814420167538.fujita.tomonori@gmail.com/T/
> 
> FUJITA Tomonori (2):
>   rust: net::phy unified read/write API for C22 and C45 registers
>   rust: net::phy unified genphy_read_status function for C22 and C45
>     registers
> 
>  MAINTAINERS                      |   1 +
>  drivers/net/phy/ax88796b_rust.rs |   7 +-
>  rust/kernel/net/phy.rs           |  44 ++-----
>  rust/kernel/net/phy/reg.rs       | 219 +++++++++++++++++++++++++++++++
>  rust/uapi/uapi_helper.h          |   1 +
>  5 files changed, 234 insertions(+), 38 deletions(-)
>  create mode 100644 rust/kernel/net/phy/reg.rs
> 
> 
> base-commit: c790275b5edf5d8280ae520bda7c1f37da460c00
> --
> 2.34.1
> 

Both patches:

Reviewed-by: Benno Lossin <benno.lossin@proton.me>

---
Cheers,
Benno