From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Changbin Du <changbin.du@intel.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <nathan@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
rust-for-linux <rust-for-linux@vger.kernel.org>,
Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size
Date: Fri, 06 May 2022 10:48:04 -0400 [thread overview]
Message-ID: <80715dbbf1f34853697e3aa6b3c74bc381000cc4.camel@HansenPartnership.com> (raw)
In-Reply-To: <CANiq72m0unKrwRrb-tnYZ5w5oodJQ+3wNHMaQazeUSCOfUBJiQ@mail.gmail.com>
On Fri, 2022-05-06 at 14:58 +0200, Miguel Ojeda wrote:
> Hi James,
>
> On Fri, May 6, 2022 at 1:19 PM James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> > When you raise KSYM_NAME_LEN to 512, this on stack allocation
> > becomes 2049 bytes. How did you manage not to trigger the frame
> > size warning, which is 1024 on 32 bit and 2048 on 64 bit by
> > default?
>
> Thanks for taking a look!
>
> If you mean `CONFIG_FRAME_WARN`, that applies to kernel objects, not
> scripts.
Oh, right, I missed that it was a script. Forget the comment then; we
only have a restricted stack inside the kernel not in userspace.
James
next prev parent reply other threads:[~2022-05-06 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 19:16 [PATCH v1 0/3] kallsyms: Rust requirements Miguel Ojeda
2022-05-05 19:16 ` [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size Miguel Ojeda
2022-05-05 23:46 ` Kees Cook
2022-05-06 5:26 ` Miguel Ojeda
2022-05-06 11:19 ` James Bottomley
2022-05-06 12:58 ` Miguel Ojeda
2022-05-06 14:48 ` James Bottomley [this message]
2022-05-05 19:16 ` [PATCH v1 2/3] kallsyms: support "big" kernel symbols Miguel Ojeda
2022-05-05 23:47 ` Kees Cook
2022-05-05 19:16 ` [PATCH v1 3/3] kallsyms: increase maximum kernel symbol length to 512 Miguel Ojeda
2022-05-05 23:48 ` Kees Cook
2022-05-06 8:34 ` Petr Mladek
2022-05-06 9:45 ` Geert Stappers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80715dbbf1f34853697e3aa6b3c74bc381000cc4.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=boqun.feng@gmail.com \
--cc=changbin.du@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).