From: Andrew Lunn <andrew@lunn.ch>
To: Guru Das Srinagesh <linux@gurudas.dev>
Cc: FUJITA Tomonori <fujita.tomonori@gmail.com>,
Trevor Gross <tmgross@umich.edu>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style
Date: Mon, 6 Jul 2026 15:05:39 +0200 [thread overview]
Message-ID: <8376fc86-be9d-4e3a-a51e-4d9ecda1b648@lunn.ch> (raw)
In-Reply-To: <20260705-net-vert-imp-v1-1-95a35ddff411@gurudas.dev>
On Sun, Jul 05, 2026 at 10:38:40PM -0700, Guru Das Srinagesh wrote:
> Convert `use` imports to vertical layout for better readability and
> maintainability.
>
> Signed-off-by: Guru Das Srinagesh <linux@gurudas.dev>
> ---
> drivers/net/phy/ax88796b_rust.rs | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/ax88796b_rust.rs b/drivers/net/phy/ax88796b_rust.rs
> index 2d24628a4e58..5a21fe09bd62 100644
> --- a/drivers/net/phy/ax88796b_rust.rs
> +++ b/drivers/net/phy/ax88796b_rust.rs
> @@ -5,7 +5,12 @@
> //!
> //! C version of this driver: [`drivers/net/phy/ax88796b.c`](./ax88796b.c)
> use kernel::{
> - net::phy::{self, reg::C22, DeviceId, Driver},
> + net::phy::{
> + self,
> + reg::C22,
> + DeviceId,
> + Driver, //
> + },
A question from somebody who does not know rust. Does the order of the
elements in the list matter?
Linux has a pattern of sorting multi line lists, because it reduces
merge conflicts. Can this list be sorted?
Andrew
next prev parent reply other threads:[~2026-07-06 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 5:38 [PATCH net-next 0/2] rust: net: Use kernel style vertical imports Guru Das Srinagesh
2026-07-06 5:38 ` [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style Guru Das Srinagesh
2026-07-06 13:05 ` Andrew Lunn [this message]
2026-07-06 13:40 ` Gary Guo
2026-07-06 13:53 ` Andrew Lunn
2026-07-06 13:45 ` Alice Ryhl
2026-07-06 5:38 ` [PATCH net-next 2/2] net: phy: qt2025: " Guru Das Srinagesh
2026-07-06 13:58 ` Andrew Lunn
2026-07-06 15:07 ` Gary Guo
2026-07-06 15:28 ` Miguel Ojeda
2026-07-06 15:51 ` Andrew Lunn
2026-07-06 16:08 ` Miguel Ojeda
2026-07-06 16:15 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8376fc86-be9d-4e3a-a51e-4d9ecda1b648@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@gurudas.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox