From: Danilo Krummrich <dakr@kernel.org>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: alex.gaynor@gmail.com, gregkh@linuxfoundation.org,
ojeda@kernel.org, rafael@kernel.org, robh@kernel.org,
saravanak@google.com, tmgross@umich.edu, a.hindborg@kernel.org,
aliceryhl@google.com, bhelgaas@google.com,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com,
david.m.ertman@intel.com, devicetree@vger.kernel.org,
gary@garyguo.net, ira.weiny@intel.com, kwilczynski@kernel.org,
lenb@kernel.org, leon@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lossin@kernel.org, netdev@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v4 0/3] rust: Build PHY device tables by using module_device_table macro
Date: Sat, 12 Jul 2025 00:19:54 +0200 [thread overview]
Message-ID: <83b1b2f4-f87c-4b3f-ab4d-84ec429abd79@kernel.org> (raw)
In-Reply-To: <20250711040947.1252162-1-fujita.tomonori@gmail.com>
On 7/11/25 6:09 AM, FUJITA Tomonori wrote:
> Build PHY device tables by using module_device_table macro.
>
> The PHY abstractions have been generating their own device tables
> manually instead of using the module_device_table macro provided by
> the device_id crate. However, the format of device tables occasionally
> changes [1] [2], requiring updates to both the device_id crate and the custom
> format used by the PHY abstractions, which is cumbersome to maintain.
>
> [1]: https://lore.kernel.org/lkml/20241119235705.1576946-14-masahiroy@kernel.org/
> [2]: https://lore.kernel.org/lkml/6e2f70b07a710e761eb68d089d96cee7b27bb2d5.1750511018.git.legion@kernel.org/
>
> Danilo, I incorporated your fixes into the first patch and mentioned
> them in the commit message. Let me know if you'd rather take a
> different approach.
Thanks FUJITA -- no need to mention it though. :)
Did you forget to pick up Jakub's ACK or was this intentional?
- Danilo
next prev parent reply other threads:[~2025-07-11 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 4:09 [PATCH v4 0/3] rust: Build PHY device tables by using module_device_table macro FUJITA Tomonori
2025-07-11 4:09 ` [PATCH v4 1/3] rust: device_id: split out index support into a separate trait FUJITA Tomonori
2025-07-11 22:23 ` Danilo Krummrich
2025-07-16 9:19 ` Greg KH
2025-07-11 4:09 ` [PATCH v4 2/3] rust: net::phy represent DeviceId as transparent wrapper over mdio_device_id FUJITA Tomonori
2025-07-11 4:09 ` [PATCH v4 3/3] rust: net::phy Change module_phy_driver macro to use module_device_table macro FUJITA Tomonori
2025-07-11 22:19 ` Danilo Krummrich [this message]
2025-07-11 22:53 ` [PATCH v4 0/3] rust: Build PHY device tables by using " FUJITA Tomonori
2025-07-14 13:22 ` Danilo Krummrich
2025-07-16 22:58 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b1b2f4-f87c-4b3f-ab4d-84ec429abd79@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=david.m.ertman@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=kwilczynski@kernel.org \
--cc=lenb@kernel.org \
--cc=leon@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).