rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Igor Korotin <igor.korotin.linux@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Asahi Lina" <lina+kernel@asahilina.net>,
	"Wedson Almeida Filho" <wedsonaf@gmail.com>,
	"Alex Hung" <alex.hung@amd.com>,
	"Tamir Duberstein" <tamird@gmail.com>,
	"Xiangfei Ding" <dingxiangfei2009@gmail.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v6 2/3] rust: i2c: Add basic I2C driver abstractions
Date: Sun, 2 Nov 2025 17:45:02 +0000	[thread overview]
Message-ID: <860306dd-b3b1-4eeb-b8b1-d09f2f7e028d@gmail.com> (raw)
In-Reply-To: <DDTFXY5VJCS2.1ZB9EPNLDTPAC@kernel.org>

Hello Danilo

On 10/27/2025 10:00 PM, Danilo Krummrich wrote:
> It's called from other drivers (e.g. DRM drivers [1] or network drivers [2])
> that are bound to some bus device themselves, e.g. a platform device or a PCI
> device.
> 
> This is the device that we can give to i2c:Registration::new() and use for the
> internal call to devres.

After the recent change where i2c::Registration::new() returns impl 
PinInit<Devres<Self>, Error> instead of Result<Self>, I’m unsure how to 
adapt the Rust I2C sample driver. The sample doesn’t have a parent 
device available — previously it just used the returned I2cClient.

The current patch series includes a Rust I2C sample driver that creates 
a new i2c_client using i2c::Registration::new() and then attaches an I2C 
driver to it. Since this is no longer possible, I’m evaluating how the 
sample should be structured.

The only option I see is to split it into two parts:
1. A minimal I2C driver sample demonstrating only driver code.
2. A separate I2C client registration sample based on an existing PCI or 
platform sample driver, using its device as the parent for Devres::new() 
inside `i2c::Registration::new()`.

Does this approach make sense, or is there a better way to handle it?

Thanks,
Igor




  parent reply	other threads:[~2025-11-02 17:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-05 10:22 [PATCH v6 0/3] rust: i2c: Add basic I2C driver abstractions Igor Korotin
2025-10-05 10:23 ` [PATCH v6 1/3] rust: i2c: add basic I2C device and " Igor Korotin
2025-10-26 10:49   ` Danilo Krummrich
2025-10-05 10:23 ` [PATCH v6 2/3] rust: i2c: add manual I2C device creation abstractions Igor Korotin
2025-10-26 10:48   ` Danilo Krummrich
2025-10-26 18:41     ` [PATCH v6 2/3] rust: i2c: Add basic I2C driver abstractions Igor Korotin
2025-10-26 19:20       ` Danilo Krummrich
2025-10-27 20:27         ` Igor Korotin
2025-10-27 22:00           ` Danilo Krummrich
2025-10-28 20:00             ` Igor Korotin
2025-11-02 17:45             ` Igor Korotin [this message]
2025-11-02 18:02               ` Danilo Krummrich
2025-10-05 10:23 ` [PATCH v6 3/3] samples: rust: add Rust I2C sample driver Igor Korotin
2025-10-26 10:48   ` Danilo Krummrich
2025-10-26 14:06     ` Igor Korotin
2025-10-26 15:43       ` Danilo Krummrich
2025-10-26 15:50         ` Igor Korotin
2025-10-26 15:55           ` Danilo Krummrich
2025-10-26  9:38 ` [PATCH v6 0/3] rust: i2c: Add basic I2C driver abstractions Igor Korotin
2025-10-26 10:52   ` Danilo Krummrich
2025-10-26 14:07     ` Igor Korotin
2025-10-26 14:25     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=860306dd-b3b1-4eeb-b8b1-d09f2f7e028d@gmail.com \
    --to=igor.korotin.linux@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=alex.hung@amd.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dingxiangfei2009@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=lina+kernel@asahilina.net \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@gmail.com \
    --cc=tmgross@umich.edu \
    --cc=viresh.kumar@linaro.org \
    --cc=wedsonaf@gmail.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).