From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 510301E7C23; Wed, 19 Feb 2025 14:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739976859; cv=none; b=A7nk+54DHG3HOwSCCATT3PGeaDbyguuo/Rscqvy/8+2/3Ua4kgbB8MyICK5FZ2mBKxZnUmPR98fZydvuyG3BDvW7MgVZoJROdgRD+Re+B/vq+HHfJ0U/6CttxxODrfLMjOK+NnEQQosDlqRYKbW20lfOmA2GSMxG/HITTXl2DSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739976859; c=relaxed/simple; bh=ePzAI0EZVkG3juq/EiW7UpGx47gYIjwV+1EpqpsAGs0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Gv0SrT3Mg/OkBtdbl5be9pev4tGv7EQpnDKxG0XmwRFOR2LWLIGpl/meJ3u1rsWTxY7C8vQRkBaIYLGpUAEuH5nuV8RHxu6/QcsiQzP6d6vNgRmzPb9Hspc9hVcVh3DBi4RxdKi/vD1C/KwITsmapF3I3WDFKfAjta2QYtYonNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jz51/1vG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jz51/1vG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E336FC4CED6; Wed, 19 Feb 2025 14:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739976859; bh=ePzAI0EZVkG3juq/EiW7UpGx47gYIjwV+1EpqpsAGs0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Jz51/1vG6qYTmy5lnSI/vzuhot9lpMUPJMnIUQqpY/DtwKfmEVG/j2xeV53hPM7Lc 2A7DStSjZ6Ss+xQhLKkme5gtGfefpTonjGej6NQde7s/otWORqOsugwT14Nd0jxhqW pKW7eO6Fqbud/g5TjsaHSzDmB2FwD+Kr4Sv+gyCW4Z3AlpuAZWAFcgJN6NCPC7nVfP ZIY6QrwXXKvwMZFdpyWEtK6XteOuF4DG2A+VsS7vI/Yen9NfNbHv2vq83QoasxS6nd +rDZbHkT0zEFPiE9Rt+BSUKgxTODk7KEFIUm61R/UwiGjqrd2FvCdXIwboWQBZiH4n YJLOtVcxjFnTQ== From: Andreas Hindborg To: "Benno Lossin" Cc: "Miguel Ojeda" , "Anna-Maria Behnsen" , "Frederic Weisbecker" , "Thomas Gleixner" , "Danilo Krummrich" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj?= =?utf-8?Q?=C3=B6rn?= Roy Baron , "Alice Ryhl" , "Trevor Gross" , "Lyude Paul" , "Guangbo Cui" <2407018371@qq.com>, "Dirk Behme" , "Daniel Almeida" , "Tamir Duberstein" , , Subject: Re: [PATCH v8 01/14] rust: time: Add Ktime::from_ns() In-Reply-To: <693e39f6-70ac-4752-b371-74a3bd1fcf16@proton.me> (Benno Lossin's message of "Wed, 19 Feb 2025 11:58:11 +0000") References: <20250218-hrtimer-v3-v6-12-rc2-v8-0-48dedb015eb3@kernel.org> <20250218-hrtimer-v3-v6-12-rc2-v8-1-48dedb015eb3@kernel.org> <693e39f6-70ac-4752-b371-74a3bd1fcf16@proton.me> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 19 Feb 2025 15:53:40 +0100 Message-ID: <871pvuc7ez.fsf@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Benno Lossin" writes: > On 18.02.25 14:27, Andreas Hindborg wrote: >> From: Lyude Paul >> >> A simple function to turn the provided value in nanoseconds into a Ktime >> value. We allow any type which implements Into, which >> resolves to Into. >> >> This is useful for some of the older DRM APIs that never got moved to >> Ktime. > > Are these older DRM APIs on the C side, or on the Rust side? If they are > on the Rust side, we should just move them to Ktime, no? > >> Signed-off-by: Lyude Paul >> Reviewed-by: Lyude Paul > > This seems wrong considering the `From Lyude Paul` line above :) (or is > it possible to review your own patch?) > > The patch itself looks good, so iff the above question is answered with > "the older DRM APIs are on the C side" then: > > Reviewed-by: Benno Lossin It occurs to me that I am actually not relying on this patch for this series any longer, so I will just drop it. Best regards, Andreas Hindborg