From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4887BC636CD for ; Tue, 7 Feb 2023 09:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231130AbjBGJeL (ORCPT ); Tue, 7 Feb 2023 04:34:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbjBGJeK (ORCPT ); Tue, 7 Feb 2023 04:34:10 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B7F019F2E for ; Tue, 7 Feb 2023 01:34:07 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id x9so6573871eds.12 for ; Tue, 07 Feb 2023 01:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=metaspace-dk.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=uDFOFGN7sf2+Ai+RMRVBWm4CW15bTwJp4mBVAUWo9XY=; b=inbW0VtmixIQRC4S+CuEjGGknQgFXxROoDl/NQ3aqIIesJhfcSDPSGx0x/89FjprjT 2OQ76T5SnGLZTfeMy8AN8Ft+kKeYqmtLn+z3o5/R8ZbyASgYdzWzgqWzklfNE5IF8STp BuWxcAIvPEVCr8x9fXnHahkflPJtZYxcfetc/FkWA7nrqKSQY1fe0ejRV1bnbUNTQaTq DkvSWYeCMAlt3N53ebM+lyRdt90USGxvL+ATIVdQeh3sAUG8TbxolgqxhOK6xrhBXfsU EWVmBbFgfljF85bc+koHsy4Qbl7G1ZQyvq+N0XISGghMNxfzAQGY8MVqFVruGNwrEH2t Y/7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uDFOFGN7sf2+Ai+RMRVBWm4CW15bTwJp4mBVAUWo9XY=; b=2KL6KKwHPkOprDGgUrM1TkYxMPra8/bY2Q2Ev+z35i+ebriPqXHZB/qGV3TJzj117t 1XErgPNF3JZmFxJAonEdZ4cacXUpI++ok/EkR5QKdPK2aQb72RqpAdDEJy6LjlnjscxA JCcI46ycJnu0/QPnaHB57s2j3NDJMFRYFdiV1+qr+X6QHj9p/r4QHbKyZElsYAisA5+9 EOqRX6guyd5mTcyJo9u+W4+lV7bB9OU2zb9Oga5AJAXShWkfqKrReNkyoftDFvKq19oX O+xqQlBfXKWDcWVAew2o9vLUpdQmXBzdXN1vtQ/LbByTLQDvXjB7PPSnNkRjAcUHt0rE U38A== X-Gm-Message-State: AO0yUKUJtmrfFGKovbvPRs4LsnaKRUe+t3ZLTOoYRPxQv6sUIjWfKT4S RMDIJqVVviyrCmpsTw/e5eS9ow== X-Google-Smtp-Source: AK7set9nJjoKGxU3DzBf3xCb0a8faWphNun1frWIlolJLyTztru0HQCur+E+ZX0R34SqnGN12eCT8Q== X-Received: by 2002:a50:bac7:0:b0:49e:eb5:ed05 with SMTP id x65-20020a50bac7000000b0049e0eb5ed05mr3058130ede.9.1675762445729; Tue, 07 Feb 2023 01:34:05 -0800 (PST) Received: from localhost ([194.62.217.4]) by smtp.gmail.com with ESMTPSA id d22-20020a50cd56000000b004aaa8e65d0esm3122923edj.84.2023.02.07.01.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 01:34:05 -0800 (PST) References: <20230130064404.744600-1-wedsonaf@gmail.com> <20230130064404.744600-5-wedsonaf@gmail.com> <87h6w5isfq.fsf@metaspace.dk> User-agent: mu4e 1.9.18; emacs 28.2.50 From: Andreas Hindborg To: Miguel Ojeda Cc: Wedson Almeida Filho , rust-for-linux@vger.kernel.org, Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , linux-kernel@vger.kernel.org, Vincenzo Palazzo , Alice Ferrazzi Subject: Re: [PATCH v2 5/5] rust: types: implement `ForeignOwnable` for `Arc` Date: Tue, 07 Feb 2023 10:32:52 +0100 In-reply-to: Message-ID: <87357hsttf.fsf@metaspace.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org Miguel Ojeda writes: > On Wed, Feb 1, 2023 at 11:35 AM Andreas Hindborg wrote: >> >> The last part of the sentence does not read clearly to me. Would this >> make sense instead: >> >> // SAFETY: By the safety requirement of this function, we know that `ptr` came from >> // a previous call to `Arc::into_foreign`, which guarantees that `ptr` is valid and >> // holds a reference count increment that is transferrable to us. > > In a private chat with Wedson he agreed the "owned" was a typo and he > is fine with this change. Thus I rebased to apply this and avoid a v3 > given it is trivial and almost at the top of the stack. If you want > the `Reviewed-by`, please let me know! Sure, if it's no trouble, add my the tag :) - Andreas