From: Fiona Behrens <me@kloenk.dev>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Boris-Chengbiao Zhou" <bobo1239@web.de>,
"Kees Cook" <kees@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Chayim Refael Friedman" <chayimfr@gmail.com>
Subject: Re: [PATCH v2] scripts: generate_rust_analyzer.py: add missing macros deps
Date: Mon, 10 Feb 2025 18:00:08 +0100 [thread overview]
Message-ID: <874j11buqv.fsf@kloenk.dev> (raw)
In-Reply-To: <CAJ-ks9m3SV4ezHda0cu00_TRLwY8mNg+GxJrji+FQMs=mfuL2w@mail.gmail.com> (Tamir Duberstein's message of "Mon, 10 Feb 2025 11:51:26 -0500")
Tamir Duberstein <tamird@gmail.com> writes:
> On Mon, Feb 10, 2025 at 11:32 AM Fiona Behrens <me@kloenk.dev> wrote:
>>
>> Competing with https://lore.kernel.org/rust-for-linux/20241205115438.234221-1-me@kloenk.dev/
>> but I do like your aproach more.
>
> Missed this one go by. Sorry!
No worries at all, was mostly also to make sure that not both gets merged.
>
>> Reviewed-by: Fiona Behrens <me@kloenk.dev>
>
> Thanks for reviewing! I'm going to respin v3 that looks a little bit
> more like https://lore.kernel.org/all/20250209-rust-analyzer-host-v1-3-a2286a2a2fa3@gmail.com/
> which is the proper fix. If you're OK with it, I'll keep your tag.
Sure, feel also free to ping on zullip if anything specific before
sending. But your code already looks very good. Like it with the types
and such.
Thanks
Fiona
prev parent reply other threads:[~2025-02-10 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 17:11 [PATCH v2] scripts: generate_rust_analyzer.py: add missing macros deps Tamir Duberstein
2025-02-09 17:34 ` Tamir Duberstein
2025-02-10 16:32 ` Fiona Behrens
2025-02-10 16:51 ` Tamir Duberstein
2025-02-10 17:00 ` Fiona Behrens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j11buqv.fsf@kloenk.dev \
--to=me@kloenk.dev \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=bobo1239@web.de \
--cc=boqun.feng@gmail.com \
--cc=chayimfr@gmail.com \
--cc=gary@garyguo.net \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox