From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425C519B595; Fri, 1 Nov 2024 13:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730467507; cv=none; b=NPFTha6pP8z24PxdCeMeoaSsaAras/Wm+wkQEmPpAu4udSk5jDgplkFA/laAFI5+bdFc/Vkvxivl5NaUTA89Pe0bqGmbk6Uux46faJnrQWK08wzslnTn5yMqFrmeMKSZSKKQ/YFkSsMfa7qIQjOOOZCLfnMxXElUs5pku2nZhb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730467507; c=relaxed/simple; bh=+gWLxkzDFu0men3WpeyM2YQpE+xw02L+EZDYwHbxjY4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kIvqeNa8FO4Zc6j/Fojps4fXoiIfKSsX/fzXYutFgQkiME7bR6C9qASJcj+VfDgM6Ces23bYK7lCGamW9DQaV0XAQHRBtZQ3g356xaKx3WyO9GK+1jlqOtHzmeDv2LiyStdirkJZSdSbxISH5b8kA9b/YzRzM5xFTVQICn4qz34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cO2cGDjr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cO2cGDjr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE903C4CECD; Fri, 1 Nov 2024 13:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730467506; bh=+gWLxkzDFu0men3WpeyM2YQpE+xw02L+EZDYwHbxjY4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cO2cGDjryYPxJ6XxWrK+/Z5kbrdHJ8Rh6JiTF6QUmQzdxXaceDflNfrcj9Ukbpq7z L8OAMsrmn5N6j7FDVSV2xQTUcBLZyFk6b2QWMNiTcZtK0GuMI81CtTU7ZtbMkhLf0x uj2pS2GwujxSiIo3z9MiYljklnf86JLCNSJsGuqyu81dT1LPcXEvDbhPi9UjjA16bf wKrbyyrx2R4a74bMalKMKbuWAijZqnSAy3KzmjnX5TDkpB/5lhzZG4TEnDIGDQPm34 yQ4SJVGe3D0yDeG/m+3WSLq1kGNRs+9FIMN9rR0X3VQ1qpxOJFlJr4+gFHGdmXMdc3 /k+EMmBBjeYUA== From: Andreas Hindborg To: "Tamir Duberstein" Cc: "Miguel Ojeda" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj?= =?utf-8?Q?=C3=B6rn?= Roy Baron , "Benno Lossin" , "Alice Ryhl" , "Trevor Gross" , "Danilo Krummrich" , , Subject: Re: [PATCH 4/5] rust: reorder `ForeignOwnable` items In-Reply-To: (Tamir Duberstein's message of "Thu, 31 Oct 2024 09:30:16 -0400") References: <20241030-borrow-mut-v1-0-8f0ceaf78eaf@gmail.com> <20241030-borrow-mut-v1-4-8f0ceaf78eaf@gmail.com> <871pzwpsm9.fsf@kernel.org> Date: Fri, 01 Nov 2024 14:24:49 +0100 Message-ID: <874j4rnl26.fsf@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Tamir Duberstein" writes: > On Thu, Oct 31, 2024 at 8:40=E2=80=AFAM Miguel Ojeda > wrote: >> >> On Thu, Oct 31, 2024 at 1:23=E2=80=AFPM Tamir Duberstein wrote: >> > >> > This change was part of the original patch. Do you prefer the code >> > movement in the same commit? >> >> If we do it, please keep it separate, that is a good idea. >> >> However, I think Andreas means to avoid the movement at all, >> regardless of which commit is used to do it. > > Understood. I'll update the commit message to explain that this also > avoids inconsistency with the implementation in kbox.rs, which is > already in this order. > > Andreas, please let me know if this is acceptable. I would prefer not to move the code, but I am not going to make more noise about it that this :) I don't care what order these items are, and so to me it is just noise in the history. Best regards, Andreas Hindborg