rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rust: improve grammar in commentary
@ 2024-10-09 16:23 ` Tamir Duberstein
  2024-10-09 18:13   ` Dirk Behme
                     ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Tamir Duberstein @ 2024-10-09 16:23 UTC (permalink / raw)
  To: rust-for-linux
  Cc: Tamir Duberstein, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, linux-kernel

Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
added an errant "the" where one was not needed; remove it.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
 rust/exports.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/rust/exports.c b/rust/exports.c
index e5695f3b45b7..fd278e272751 100644
--- a/rust/exports.c
+++ b/rust/exports.c
@@ -3,9 +3,9 @@
  * A hack to export Rust symbols for loadable modules without having to redo
  * the entire `include/linux/export.h` logic in Rust.
  *
- * This requires the Rust's new/future `v0` mangling scheme because the default
- * one ("legacy") uses invalid characters for C identifiers (thus we cannot use
- * the `EXPORT_SYMBOL_*` macros).
+ * This requires Rust's new/future `v0` mangling scheme because the default one
+ * ("legacy") uses invalid characters for C identifiers (thus we cannot use the
+ * `EXPORT_SYMBOL_*` macros).
  *
  * All symbols are exported as GPL-only to guarantee no GPL-only feature is
  * accidentally exposed.
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: improve grammar in commentary
  2024-10-09 16:23 ` [PATCH] rust: improve grammar in commentary Tamir Duberstein
@ 2024-10-09 18:13   ` Dirk Behme
  2024-10-10  8:37   ` Alice Ryhl
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Dirk Behme @ 2024-10-09 18:13 UTC (permalink / raw)
  To: Tamir Duberstein, rust-for-linux
  Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, linux-kernel

Am 09.10.24 um 18:23 schrieb Tamir Duberstein:
> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Dirk Behme <dirk.behme@gmail.com>

Thanks

Dirk

> ---
>   rust/exports.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/rust/exports.c b/rust/exports.c
> index e5695f3b45b7..fd278e272751 100644
> --- a/rust/exports.c
> +++ b/rust/exports.c
> @@ -3,9 +3,9 @@
>    * A hack to export Rust symbols for loadable modules without having to redo
>    * the entire `include/linux/export.h` logic in Rust.
>    *
> - * This requires the Rust's new/future `v0` mangling scheme because the default
> - * one ("legacy") uses invalid characters for C identifiers (thus we cannot use
> - * the `EXPORT_SYMBOL_*` macros).
> + * This requires Rust's new/future `v0` mangling scheme because the default one
> + * ("legacy") uses invalid characters for C identifiers (thus we cannot use the
> + * `EXPORT_SYMBOL_*` macros).
>    *
>    * All symbols are exported as GPL-only to guarantee no GPL-only feature is
>    * accidentally exposed.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: improve grammar in commentary
  2024-10-09 16:23 ` [PATCH] rust: improve grammar in commentary Tamir Duberstein
  2024-10-09 18:13   ` Dirk Behme
@ 2024-10-10  8:37   ` Alice Ryhl
  2024-10-10  9:33   ` Andreas Hindborg
  2024-10-21 18:12   ` Miguel Ojeda
  3 siblings, 0 replies; 5+ messages in thread
From: Alice Ryhl @ 2024-10-10  8:37 UTC (permalink / raw)
  To: Tamir Duberstein
  Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg,
	Trevor Gross, linux-kernel

On Wed, Oct 9, 2024 at 6:24 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: improve grammar in commentary
  2024-10-09 16:23 ` [PATCH] rust: improve grammar in commentary Tamir Duberstein
  2024-10-09 18:13   ` Dirk Behme
  2024-10-10  8:37   ` Alice Ryhl
@ 2024-10-10  9:33   ` Andreas Hindborg
  2024-10-21 18:12   ` Miguel Ojeda
  3 siblings, 0 replies; 5+ messages in thread
From: Andreas Hindborg @ 2024-10-10  9:33 UTC (permalink / raw)
  To: Tamir Duberstein
  Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Alice Ryhl, Trevor Gross,
	linux-kernel

"Tamir Duberstein" <tamird@gmail.com> writes:

> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>


Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rust: improve grammar in commentary
  2024-10-09 16:23 ` [PATCH] rust: improve grammar in commentary Tamir Duberstein
                     ` (2 preceding siblings ...)
  2024-10-10  9:33   ` Andreas Hindborg
@ 2024-10-21 18:12   ` Miguel Ojeda
  3 siblings, 0 replies; 5+ messages in thread
From: Miguel Ojeda @ 2024-10-21 18:12 UTC (permalink / raw)
  To: Tamir Duberstein
  Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
	Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
	Trevor Gross, linux-kernel

On Wed, Oct 9, 2024 at 6:24 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Commit e26fa546042a ("rust: kbuild: auto generate helper exports")
> added an errant "the" where one was not needed; remove it.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>

Applied to `rust-next` -- thanks everyone!

    [ Reworded title. - Miguel ]

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-10-21 18:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <kX17aeHUp5umwe5GCvm343i1wHKu96HLE6jtd3snAIynN1YBqXUkgIGJ-w9DqSTSw57ULD4FhE3NpZQwi7Q0rg==@protonmail.internalid>
2024-10-09 16:23 ` [PATCH] rust: improve grammar in commentary Tamir Duberstein
2024-10-09 18:13   ` Dirk Behme
2024-10-10  8:37   ` Alice Ryhl
2024-10-10  9:33   ` Andreas Hindborg
2024-10-21 18:12   ` Miguel Ojeda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).