From: Thomas Gleixner <tglx@linutronix.de>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>, boqun.feng@gmail.com
Cc: fujita.tomonori@gmail.com, anna-maria@linutronix.de,
frederic@kernel.org, jstultz@google.com, sboyd@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rust-for-linux@vger.kernel.org, andrew@lunn.ch,
hkallweit1@gmail.com, tmgross@umich.edu, ojeda@kernel.org,
alex.gaynor@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@samsung.com, aliceryhl@google.com, arnd@arndb.de
Subject: Re: [PATCH v4 4/7] rust: time: Add wrapper for fsleep function
Date: Tue, 29 Oct 2024 08:55:50 +0100 [thread overview]
Message-ID: <87cyjj2vi1.ffs@tglx> (raw)
In-Reply-To: <20241029.083029.72679397436968362.fujita.tomonori@gmail.com>
On Tue, Oct 29 2024 at 08:30, FUJITA Tomonori wrote:
> On Sun, 27 Oct 2024 21:38:41 -0700
> Boqun Feng <boqun.feng@gmail.com> wrote:
>> That also works for me, but an immediate question is: do we put
>> #[must_use] on `fsleep()` to enforce the use of the return value? If
>> yes, then the normal users would need to explicitly ignore the return
>> value:
>>
>> let _ = fsleep(1sec);
>>
>> The "let _ =" would be a bit annoying for every user that just uses a
>> constant duration.
>
> Yeah, but I don't think that we have enough of an excuse here to break
> the rule "Do not crash the kernel".
>
> Another possible option is to convert an invalid argument to a safe
> value (e.g., the maximum), possibly with WARN_ON_ONCE().
That makes sense.
next prev parent reply other threads:[~2024-10-29 7:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 3:31 [PATCH v4 0/7] rust: Add IO polling FUJITA Tomonori
2024-10-25 3:31 ` [PATCH v4 1/7] rust: time: Add PartialEq/Eq/PartialOrd/Ord trait to Ktime FUJITA Tomonori
2024-10-25 4:29 ` Trevor Gross
2024-10-25 3:31 ` [PATCH v4 2/7] rust: time: Introduce Delta type FUJITA Tomonori
2024-10-25 22:33 ` Andrew Lunn
2024-10-25 3:31 ` [PATCH v4 3/7] rust: time: Introduce Instant type FUJITA Tomonori
2024-10-25 20:55 ` Boqun Feng
2024-10-25 3:31 ` [PATCH v4 4/7] rust: time: Add wrapper for fsleep function FUJITA Tomonori
2024-10-25 22:03 ` Boqun Feng
2024-10-26 0:16 ` Boqun Feng
2024-10-28 0:50 ` FUJITA Tomonori
2024-10-28 4:38 ` Boqun Feng
2024-10-28 23:30 ` FUJITA Tomonori
2024-10-29 7:55 ` Thomas Gleixner [this message]
2024-10-31 8:31 ` FUJITA Tomonori
2024-10-25 3:31 ` [PATCH v4 5/7] MAINTAINERS: rust: Add TIMEKEEPING and TIMER abstractions FUJITA Tomonori
2024-10-25 3:31 ` [PATCH v4 6/7] rust: Add read_poll_timeout functions FUJITA Tomonori
2024-10-25 3:31 ` [PATCH v4 7/7] net: phy: qt2025: Wait until PHY becomes ready FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyjj2vi1.ffs@tglx \
--to=tglx@linutronix.de \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=hkallweit1@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).