From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E44317C21E; Tue, 8 Jul 2025 13:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751980954; cv=none; b=CxVCPLkjmptcoe0OsStzPXgb1E24c5TLUoWmsQwaMSLUGDeDyZwCIDZoupDyI/yw0UlaOy04wS9Tmuqvu//geCMP8aKT8pgDm1uoLWtUiST1tJVEkAze2dzgKEGd2KxGo+FE1qLfe5cMBtD2icvp64DZqM7OSMXEoishDREKLys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751980954; c=relaxed/simple; bh=+T7k4pW9zu9L9kYieKGcZhmdFngMDzLfDLPI/Y816oo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UWByW4lBcvkB0pM+pHZg7tCN1ijnQtZrbLPrwEXsG63sxpTmkpYUUfnNeOC+B4FaXJbygmZ8VbNPAXn47LrSObvBrMZf6ep35AqLh5/TWihGSchwsEyytkb4BmaAWWS5xFDxZytfVumXP7uz7ZI71xURzi/2ce4TmmvLMkxt5M8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FLebeMfV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FLebeMfV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12298C4CEED; Tue, 8 Jul 2025 13:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751980953; bh=+T7k4pW9zu9L9kYieKGcZhmdFngMDzLfDLPI/Y816oo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FLebeMfVVuXhCgT8P3SHPbIzW4hPVNUbPFYWcLJXNSBk04spAGa2H8uq84xBo8Cuh 7wqfk0zqhwCa9LmqP3A7IE9scxBtVrv2N4OYgzjF9r0XUg6aAqFX8BGwGer6deBJlV vymHhORihOfuvjORkBD2jAiXVyexoVoXoC1s7JtlFgfUlHLw5vs+e2X0GhpZTk1NhR 1Pu+gHhZHgA5YjjvbQ2TFEqGlWaP1zUqEu2+mzHSAbWYNmjKp3ZviRGA02hvLmib/K yDY/Y3r4TlVigQ9yKqvqYoHU3rVO8dgVZ20S0h82qgmcJxqZ1vTRlSqVjAqdXW4j5N EIlY3Tsi/mpuw== From: Andreas Hindborg To: "Miguel Ojeda" Cc: "Oliver Mangold" , "Benno Lossin" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , "Alice Ryhl" , "Trevor Gross" , "Asahi Lina" , , Subject: Re: [PATCH v11 1/4] rust: types: Add Ownable/Owned types In-Reply-To: (Miguel Ojeda's message of "Tue, 08 Jul 2025 12:16:19 +0200") References: <20250618-unique-ref-v11-0-49eadcdc0aa6@pm.me> <20250618-unique-ref-v11-1-49eadcdc0aa6@pm.me> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Tue, 08 Jul 2025 15:22:26 +0200 Message-ID: <87ecuqom0d.fsf@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Miguel Ojeda" writes: > On Tue, Jul 8, 2025 at 11:57=E2=80=AFAM Oliver Mangold wrote: >> >> Note, though, that I already moved it from types.rs to types/ownable.rs = on >> request. It seems to me different people here have different ideas where= it >> should be placed. I feel now, that it would make sense to come to an >> agreement between the interested parties about where it should finally be >> placed, before I move it again. Could I ask that we settle that question >> once and for all before my next revision? > > Yeah, if there is a disagreement with something said previously, then > it should be resolved before starting to ping-pong between approaches > with more and more patch versions. Reviewers can forget or they may > not have read an earlier comment, but you did the right thing > mentioning there is such a conflict in opinions. Didn't we start with this placed in the top level kernel crate? Anyway, I think it should go next to `ARef` and `AlwaysRefCounted`, which is in `types`. I think I asked to have it moved to a submodule at some point to keep types.rs manageable. If we place this one to top level, we should move `ARef` and `AlwaysRefCounted` as well. Best regards, Andreas Hindborg