Re: [PATCH 01/10] rust: Rename timer_container_of() to hrtimer_container_of()

[Andreas Hindborg <a.hindborg@kernel.org>]

Andreas Hindborg <a.hindborg@kernel.org> writes:

> "Ingo Molnar" <mingo@kernel.org> writes:
>
>> * Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>>> "Ingo Molnar" <mingo@kernel.org> writes:
>>>
>>> > This primitive is dealing with 'struct hrtimer' objects, not
>>> > 'struct timer_list' objects - so clarify the name.
>>> >
>>> > We want to introduce the timer_container_of() symbol in the kernel
>>> > for timer_list, make sure there's no clash of namespaces, at least
>>> > on the conceptual plane.
>>>
>>> Is this a resend?
>>
>> I noted the changes in the boilerplate:
>>
>>   Changes in -v3:
>>
>>     - Picked up review tags
>>     - Rebased to v6.15-rc5
>>
>> This particular patch didn't change.
>
> Thanks. I didn't get the cover letter, but I should have looked for it.
>
>>
>>> Again, I think this change is unnecessary. Please see my earlier reply [1].
>>>
>>> Best regards,
>>> Andreas Hindborg
>>>
>>>
>>> [1] https://lore.kernel.org/all/877c3cbdq2.fsf@kernel.org
>>
>> Yeah, saw that, but you said you are fine with it if I insist, and I'd
>> like to have this to free up the timer_* namespace.
>
> Yes. I did not hear any proper insisting till now though.
>
>> Since I think we'd
>> like to introduce the timer_container_of() in the future it would be
>> nice to do this rename, as:
>>
>> 	$ git grep -w timer_container_of
>>
>> will have hrtimer related false positive hits in rust/ code, even
>> though the namespaces are obviously independent.
>
> Ok, I see. I'm not used to grepping like that, but I see how that can be
> annoying.
>
>>
>> The Rust method is arguably a minor misnomer as well: you have
>> work_container_of around struct work, but timer_container_of is around
>> struct hrtimer?
>
> Yes, you are right.
>
> Feel free to take this through tip. Otherwise maybe Miguel can pick it
> up in the rust PR for 6.15.

Sorry, I meant 6.16 of course.


Best regards,
Andreas Hindborg