From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFBDE2673A9; Tue, 18 Feb 2025 13:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739884244; cv=none; b=mXYTo5c3atik+yd50SOXi5wriLtFeYzszG8qLMeMYYRdEUutReIIUKRkgfyFyUHbAVLha5Biwx2VNos0peA7BC2OBJVPjvNsnc8Z+7hXRDLzKgR71KkXB47uZDIXVzGPzYrQAmUxqND7u/s1fdGhfymDih5CcxTpK8SQMpBJ3rA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739884244; c=relaxed/simple; bh=zeUTGsaNbP48jDpGJJxMyCS/5rb77E4H2ZuUqgrfnj4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=R327ZFQpbd9Q5jpbsBgioDFGwwuwPdZtbguj+0qdD4FsSnpcDsxMQvmpeqEtDyAyGNjsdOwqhK5T3kZS8jTvLO29TK5dkAOfZHEbG9kaDqI1b0sFr27BKqUEvPuFPBNT2JF68LlGFkZI2XWXRXHYDE8hbgf3shomn6aLF9o4YPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RSKGguFo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RSKGguFo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 532F9C4CEE2; Tue, 18 Feb 2025 13:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739884244; bh=zeUTGsaNbP48jDpGJJxMyCS/5rb77E4H2ZuUqgrfnj4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RSKGguFoGbyTWnrkPEjFbsRmB3TMpDwakbuvgSg6iJ/DQOFRlcAVKUDL06JN8rSz5 IMFiESO2rrv+HfOnozvrTAfYfxAHq2v4+ZLJTMxU2SpD3BZH4X4rRq63O4HMYb4479 bL7HhRz8ubqP6th9YME5GjhGpvVXXjDdXSy7tUcUeJ7CCktK/9sXQ2JNWANZV+0+Qx 9ojIIlvf4KHaPqEKbkojfbT713JaQkWljQEl1Y5vBhV51hwYueRvOBWJWzVyM92bEN lgsAbex1VfDRN544EOAGlL0ZWMAQCRdaNXa7xexk+52fK4/soP/X8prviCRDpMkFxE akomelMLb5G4w== From: Andreas Hindborg To: "Danilo Krummrich" Cc: "Benno Lossin" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj?= =?utf-8?Q?=C3=B6rn?= Roy Baron , "Alice Ryhl" , "Trevor Gross" , "Joel Becker" , "Christoph Hellwig" , "Peter Zijlstra" , "Ingo Molnar" , "Will Deacon" , "Waiman Long" , "Fiona Behrens" , "Charalampos Mitrodimas" , , Subject: Re: [PATCH v2 2/3] rust: configfs: introduce rust support for configfs In-Reply-To: (Danilo Krummrich's message of "Tue, 18 Feb 2025 14:00:40 +0100") References: <20250207-configfs-v2-0-f7a60b24d38e@kernel.org> <20250207-configfs-v2-2-f7a60b24d38e@kernel.org> <87h64su8ux.fsf@kernel.org> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 18 Feb 2025 14:10:29 +0100 Message-ID: <87frkbflfe.fsf@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Danilo Krummrich" writes: > On Mon, Feb 17, 2025 at 12:08:22PM +0100, Andreas Hindborg wrote: >> "Benno Lossin" writes: >> >> > On 07.02.25 15:41, Andreas Hindborg wrote: [...] >> >> + /// Implementations can use this method to do house keeping before >> >> + /// `configfs` drops its reference to `Child`. >> >> + fn drop_item( >> > >> > `drop` doesn't really fit here, I think something like `unlink_item` >> > fits better, since the child isn't actually dropped after this function >> > returns. >> >> Yea, I know. But the function is called `drop_item` on the C side of >> things. Usually we keep the C names. > > I agree C names should be kept as possible. > > To me it seems obvious from the context, but maybe it'd still makes sense to add > a brief note that this callback's name is not related to 'drop' in the sense of > Rust? Yes, good idea. I'll get than in for v4. Best regards, Andreas Hindborg