From: Charalampos Mitrodimas <charmitro@posteo.net>
To: Zijing Zhang <zijing.zhang@ry.rs>
Cc: dakr@kernel.org, ojeda@kernel.org, bhelgaas@google.com,
kwilczynski@kernel.org, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] rust: pci: add config space accessors (and a small in-tree user)
Date: Sat, 31 Jan 2026 02:25:45 +0000 [thread overview]
Message-ID: <87h5s2zffe.fsf@posteo.net> (raw)
In-Reply-To: <20260131021803.1146484-1-zijing.zhang@ry.rs>
Zijing Zhang <zijing.zhang@ry.rs> writes:
> Hi Charalampos,
>
> Thanks a lot for the review and for testing the RFC series (and for the Tested-by).
> Much appreciated.
>
> It turns out I missed that PCI config space support for Rust has already landed via
> Zhi Wang’s series:
> https://lore.kernel.org/rust-for-linux/20260121202212.4438-1-zhiw@nvidia.com/
>
> So my RFC is redundant and I’ll stop pushing it to avoid wasting reviewers’ time.
> Sorry for the noise.
Mistakes happen, I also missed it myself.
Cheers,
C. Mitrodimas
>
> However, Gary pointed out a real usability/doc issue in the current API: while
> `ConfigSpaceKind`/`ConfigSpaceSize` are re-exported from `kernel::pci`, the
> `ConfigSpace` struct itself is not, which makes it hard to name the returned type
> from `Device::config_space*()` and also affects rustdoc.
>
> I’ll send a small follow-up patch to re-export `ConfigSpace` from `kernel::pci`
> shortly.
>
> Thanks again,
> Zijing
next prev parent reply other threads:[~2026-01-31 2:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 17:10 [RFC PATCH 0/2] rust: pci: add config space accessors (and a small in-tree user) Zijing Zhang
2026-01-30 17:10 ` [RFC PATCH 1/2] rust: pci: add config space accessors Zijing Zhang
2026-01-30 17:10 ` [RFC PATCH 2/2] samples: rust: pci: exercise " Zijing Zhang
2026-01-31 0:46 ` [RFC PATCH 0/2] rust: pci: add config space accessors (and a small in-tree user) Charalampos Mitrodimas
2026-01-31 2:18 ` Zijing Zhang
2026-01-31 2:25 ` Charalampos Mitrodimas [this message]
2026-01-31 0:55 ` Gary Guo
2026-01-31 1:03 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5s2zffe.fsf@posteo.net \
--to=charmitro@posteo.net \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=zijing.zhang@ry.rs \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox