rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Hindborg <a.hindborg@kernel.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Breno Leitao" <leitao@debian.org>,
	linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 07/18] rust: configfs: re-export `configfs_attrs` from `configfs` module
Date: Fri, 15 Aug 2025 10:29:15 +0200	[thread overview]
Message-ID: <87ikipdm3o.fsf@t14s.mail-host-address-is-not-set> (raw)
In-Reply-To: <aJ7sQF6ObVlwX3U0@google.com>

"Alice Ryhl" <aliceryhl@google.com> writes:

> On Fri, Aug 15, 2025 at 09:30:42AM +0200, Andreas Hindborg wrote:
>> Re-export `configfs_attrs` from `configfs` module, so that users can import
>> the macro from the `configfs` module rather than the root of the `kernel`
>> crate.
>>
>> Also update users to import from the new path.
>>
>> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>
>>  rust/kernel/configfs.rs       | 2 ++
>>  samples/rust/rust_configfs.rs | 2 +-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs
>> index 2736b798cdc6..0ca35ca8acb8 100644
>> --- a/rust/kernel/configfs.rs
>> +++ b/rust/kernel/configfs.rs
>> @@ -121,6 +121,8 @@
>>  use core::cell::UnsafeCell;
>>  use core::marker::PhantomData;
>>
>> +pub use crate::configfs_attrs;
>
> In other re-exports of macros, we've placed it immediately after the
> macro_rules! declaration.

Ok, makes sense. I'll move it.


Best regards,
Andreas Hindborg




  reply	other threads:[~2025-08-15  8:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15  7:30 [PATCH v5 00/18] rnull: add configfs, remote completion to rnull Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 01/18] rust: str: normalize imports in `str.rs` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 02/18] rust: str: allow `str::Formatter` to format into `&mut [u8]` Andreas Hindborg
2025-08-27 12:48   ` Daniel Almeida
2025-08-29 11:18     ` Andreas Hindborg
2025-08-29 18:27       ` Konstantin Ryabitsev
2025-09-01  7:58         ` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 03/18] rust: str: expose `str::{Formatter, RawFormatter}` publicly Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 04/18] rust: str: introduce `NullTerminatedFormatter` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 05/18] rust: str: introduce `kstrtobool` function Andreas Hindborg
2025-08-15  7:57   ` Alice Ryhl
2025-08-15  8:21     ` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 06/18] rust: str: add `bytes_to_bool` helper function Andreas Hindborg
2025-08-15  8:12   ` Alice Ryhl
2025-08-15  8:28     ` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 07/18] rust: configfs: re-export `configfs_attrs` from `configfs` module Andreas Hindborg
2025-08-15  8:13   ` Alice Ryhl
2025-08-15  8:29     ` Andreas Hindborg [this message]
2025-08-15  7:30 ` [PATCH v5 08/18] rust: block: normalize imports for `gen_disk.rs` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 09/18] rust: block: use `NullTerminatedFormatter` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 10/18] rust: block: remove `RawWriter` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 11/18] rust: block: remove trait bound from `mq::Request` definition Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 12/18] rust: block: add block related constants Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 13/18] rnull: move driver to separate directory Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 14/18] rnull: enable configuration via `configfs` Andreas Hindborg
2025-08-15  8:17   ` Alice Ryhl
2025-08-15  9:04     ` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 15/18] rust: block: add `GenDisk` private data support Andreas Hindborg
2025-08-15  8:18   ` Alice Ryhl
2025-08-15  9:08     ` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 16/18] rust: block: mq: fix spelling in a safety comment Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 17/18] rust: block: add remote completion to `Request` Andreas Hindborg
2025-08-15  7:30 ` [PATCH v5 18/18] rnull: add soft-irq completion support Andreas Hindborg
2025-08-15  8:21   ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikipdm3o.fsf@t14s.mail-host-address-is-not-set \
    --to=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=axboe@kernel.dk \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=leitao@debian.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).