From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] rust: block,core: rename `RawWriter` to `BufferWriter`
Date: Tue, 08 Jul 2025 10:44:34 +0200 [thread overview]
Message-ID: <87ikk3oyvh.fsf@kernel.org> (raw)
In-Reply-To: <CANiq72kcR2Mct=uTzDQrWzAFOePsxG8Y=pS_6aGocbAe+Xaimw@mail.gmail.com> (Miguel Ojeda's message of "Mon, 07 Jul 2025 20:25:27 +0200")
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> writes:
> On Mon, Jul 7, 2025 at 4:58 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>> The null insertion at the call site should be removed, it's a leftover
>> from before `BufferWriter` handled that.
>
> Just in case -- I think that if you do that then you would only get
> the null terminator at the end of the buffer.
>
> i.e. the one your formatter (`RawWriter`) places is really at the end
> of the buffer, rather than immediately after your formatted text, so
> if you don't have the one at the call site, you would end with garbage
> in the middle unless the disk name fits perfectly into the buffer.
I'll be sure to thoroughly check everything. Thanks for taking a look.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-07-08 8:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 13:23 [PATCH 0/9] rnull: add configfs, remote completion to rnull Andreas Hindborg
2025-06-16 13:23 ` [PATCH 1/9] rust: block: remove trait bound from `mq::Request` definition Andreas Hindborg
2025-06-16 13:23 ` [PATCH 2/9] rust: block: add block related constants Andreas Hindborg
2025-06-16 13:23 ` [PATCH 3/9] rust: block,core: rename `RawWriter` to `BufferWriter` Andreas Hindborg
2025-07-07 14:18 ` Miguel Ojeda
2025-07-07 14:58 ` Andreas Hindborg
2025-07-07 18:25 ` Miguel Ojeda
2025-07-08 8:44 ` Andreas Hindborg [this message]
2025-06-16 13:23 ` [PATCH 4/9] rnull: move driver to separate directory Andreas Hindborg
2025-06-16 13:23 ` [PATCH 5/9] rnull: enable configuration via `configfs` Andreas Hindborg
2025-06-16 13:23 ` [PATCH 6/9] rust: block: add `GenDisk` private data support Andreas Hindborg
2025-06-16 13:23 ` [PATCH 7/9] rust: block: mq: fix spelling in a safety comment Andreas Hindborg
2025-06-16 13:23 ` [PATCH 8/9] rust: block: add remote completion to `Request` Andreas Hindborg
2025-06-16 13:23 ` [PATCH 9/9] rnull: add soft-irq completion support Andreas Hindborg
2025-06-16 13:56 ` Johannes Thumshirn
2025-06-17 8:08 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikk3oyvh.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=axboe@kernel.dk \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).