Re: [PATCH v6 3/7] rust: hrtimer: Add HrTimer::raw_forward() and forward()

[Andreas Hindborg <a.hindborg@kernel.org>]

"Daniel Almeida" <daniel.almeida@collabora.com> writes:

> […]
>
>
>> +
>> +    /// Conditionally forward the timer.
>> +    ///
>> +    /// If the timer expires after `now`, this function does nothing and returns 0. If the timer
>> +    /// expired at or before `now`, this function forwards the timer by `interval` until the timer
>> +    /// expires after `now` and then returns the number of times the timer was forwarded by
>> +    /// `interval`.
>> +    ///
>> +    /// Returns the number of overruns that occurred as a result of the timer expiry change.
>> +    pub fn forward(self: Pin<&mut Self>, now: HrTimerInstant<T>, interval: Delta) -> u64
>> +    where
>> +        T: HasHrTimer<T>,
>> +    {
>> +        // SAFETY:
>> +        // - `raw_forward` does not move `self`.
>> +        // - Self is a mutable reference and thus always points to a valid `HrTimer`
>
> I get what you're trying to say, but IMHO using the word "mutable" here is
> confusing. Mutability has nothing to do on whether something is valid. This
> should be rephrased, IMHO.

Having a reference to something implies validity. We could do:

  The coertion of `&mut Self` to `*mut Self` results in a pointer to a
  valid `Self`.


Best regards,
Andreas Hindborg