From: Andreas Hindborg <a.hindborg@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
FUJITA Tomonori <fujita.tomonori@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Lyude Paul <lyude@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [GIT PULL] Rust timekeeping for v6.18
Date: Mon, 22 Sep 2025 10:22:30 +0200 [thread overview]
Message-ID: <87ldm6x5fd.fsf@t14s.mail-host-address-is-not-set> (raw)
In-Reply-To: <CANiq72=33y3L8oN7d1BaKpD6TxEzhVKUnyx7BGyX+z+HdQtUBg@mail.gmail.com>
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com> writes:
> On Fri, Sep 19, 2025 at 1:46 PM Andreas Hindborg <a.hindborg@kernel.org> wrote:
>>
>> - Additional functionality for `HrTimer` that allows use of operations
>> that can only be executed in timer callback context, or with
>> exclusive access to a timer that is not armed.
>
> Should I use this one or the bullet from the tag itself?
I would suggest you use the info in the tag.
> (For future PRs, please avoid duplicating the summary, i.e. the part
> that goes outside the tag message should generally be about meta
> comments that should not go into the repository, like the linux-next
> note.)
I am actually a bit confused as to what information you prefer in the
tag and what you prefer in the pull request message itself. I would
appreciate a reminder to use as a guideline. They seem redundant to me,
which is why I used an empty tag last cycle.
>
> By the way, I noticed a commit without a commit message apart from the
> title and tags -- for future PRs, please try to always ensure there is
> some context, especially explaining why something is added:
>
> ac0a7bd27f65 ("rust: hrtimer: Add forward_now() to HrTimer and
> HrTimerCallbackContext")
Thanks, I missed that somehow. Usually `check_patch.pl` will complain
for this kind of thing.
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-09-22 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 11:46 [GIT PULL] Rust timekeeping for v6.18 Andreas Hindborg
2025-09-21 19:26 ` Miguel Ojeda
2025-09-22 8:22 ` Andreas Hindborg [this message]
2025-09-22 9:12 ` Miguel Ojeda
2025-09-22 20:31 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldm6x5fd.fsf@t14s.mail-host-address-is-not-set \
--to=a.hindborg@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=jstultz@google.com \
--cc=lyude@redhat.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).