From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Antonio Hickey" <contact@antoniohickey.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 17/17] rust: clippy: disallow `addr_of[_mut]!` macros
Date: Thu, 20 Mar 2025 08:33:24 +0100 [thread overview]
Message-ID: <87ldt0dum3.fsf@kernel.org> (raw)
In-Reply-To: <20250320020740.1631171-18-contact@antoniohickey.com> (Antonio Hickey's message of "Wed, 19 Mar 2025 22:07:36 -0400")
"Antonio Hickey" <contact@antoniohickey.com> writes:
> With the `raw_ref_op` feature enabled we no longer want to
> allow use of the `addr_of!` and `addr_of_mut!` macros.
>
> We instead want to use `&raw const` and `&raw mut` to get raw
> pointers to a place.
>
> Note that this lint isn't currently reliable, but we enable
> it nevertheless because:
> 1. Document that one shouldn't use the `addr_of[_mut]!` macros.
> 2. When the lint becomes useful we will already have it enabled.
>
> Suggested-by: Benno Lossin <benno.lossin@proton.me>
> Link: https://github.com/Rust-for-Linux/linux/issues/1148
> Link: https://github.com/rust-lang/rust-clippy/issues/11431
> Signed-off-by: Antonio Hickey <contact@antoniohickey.com>
Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-03-20 7:34 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 2:07 [PATCH v5 00/17] refactor to utilize `&raw [const|mut]` Antonio Hickey
2025-03-20 2:07 ` [PATCH v5 01/17] rust: enable `raw_ref_op` feature Antonio Hickey
2025-03-20 7:32 ` Andreas Hindborg
2025-03-22 10:16 ` Benno Lossin
2025-03-22 15:02 ` Antonio Hickey
2025-03-22 18:24 ` Tamir Duberstein
2025-03-22 19:12 ` Antonio Hickey
2025-03-22 19:39 ` Benno Lossin
2025-03-22 19:41 ` Miguel Ojeda
2025-03-22 20:12 ` Antonio Hickey
2025-03-20 2:07 ` [PATCH v5 02/17] rust: init: refactor to use `&raw [const|mut]` Antonio Hickey
2025-03-23 10:29 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 03/17] rust: list: " Antonio Hickey
2025-03-23 10:31 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 04/17] rust: task: remove use of `addr_of!` macro Antonio Hickey
2025-03-23 19:23 ` Miguel Ojeda
2025-03-20 2:07 ` [PATCH v5 05/17] rust: faux: refactor to use `&raw [const|mut]` Antonio Hickey
2025-03-23 10:33 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 06/17] rust: platform: " Antonio Hickey
2025-03-23 10:33 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 07/17] rust: pci: " Antonio Hickey
2025-03-23 10:34 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 08/17] rust: kunit: " Antonio Hickey
2025-03-23 10:35 ` Benno Lossin
2025-03-23 19:28 ` Miguel Ojeda
2025-03-20 2:07 ` [PATCH v5 09/17] rust: workqueue: " Antonio Hickey
2025-03-23 10:36 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 10/17] rust: workqueue: replace `raw_get` with pointer cast Antonio Hickey
2025-03-20 2:07 ` [PATCH v5 11/17] rust: rbtree: refactor to use `&raw [const|mut]` Antonio Hickey
2025-03-23 10:38 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 12/17] rust: net: phy: " Antonio Hickey
2025-03-20 2:07 ` [PATCH v5 13/17] rust: sync: arc: " Antonio Hickey
2025-03-23 10:39 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 14/17] rust: jump_label: " Antonio Hickey
2025-03-23 10:40 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 15/17] rust: fs: file: " Antonio Hickey
2025-03-23 10:40 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 16/17] rust: block: " Antonio Hickey
2025-03-20 7:33 ` Andreas Hindborg
2025-03-23 10:41 ` Benno Lossin
2025-03-20 2:07 ` [PATCH v5 17/17] rust: clippy: disallow `addr_of[_mut]!` macros Antonio Hickey
2025-03-20 7:33 ` Andreas Hindborg [this message]
2025-03-23 10:41 ` Benno Lossin
2025-03-23 10:45 ` [PATCH v5 00/17] refactor to utilize `&raw [const|mut]` Benno Lossin
2025-03-23 22:32 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldt0dum3.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=contact@antoniohickey.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).